Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH 0/6] [C++] Drop -fpermissive hack, enable -Werror
Date: Wed, 18 Nov 2015 17:44:00 -0000	[thread overview]
Message-ID: <564CB8EC.5000203@gmail.com> (raw)
In-Reply-To: <1447864802-24016-1-git-send-email-palves@redhat.com>

On 18/11/15 16:39, Pedro Alves wrote:
> The first 4 patches finally make GDB build cleanly in C++, at least on
> x86_64 GNU/Linux and x86_64 mingw.  At this point, I think we should
> drop the -fpermissive hack and default to -Werror in C++ mode too,
> which is what the last two patches do.

Yeah! Good to see the switch to C++ will happen soon.  Thanks, Pedro
and Simon.

>
> This lets the buildbot catch C++ build regressions promptly -- we
> already have a Fedora buildslave building in C++ mode specifically for
> that, but it currently misses regressions around pointer casts and
> enum conversions exactly due to -fpermissive/-Wno-error.
>
> Other ports still need further C++ conversion work, though the build
> failures shouldn't be too many and should be mostly localized to
> host/target-specific code.

I don't have objections to this patch set, just want to know what is
your plan to commit it.  I'll fix C++ warnings and errors in ARM
and AArch64 code.

-- 
Yao (齐尧)


  parent reply	other threads:[~2015-11-18 17:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 16:40 Pedro Alves
2015-11-18 16:40 ` [PATCH 1/6] [C++] remote.c: Avoid enum arithmetic Pedro Alves
2015-11-18 16:40 ` [PATCH 3/6] [C++] s390: Fix enum gdb_syscall conversion Pedro Alves
2015-11-18 16:40 ` [PATCH 2/6] [C++] linux-thread-db.c: dladdr cast Pedro Alves
2015-11-18 16:40 ` [PATCH 4/6] [C++] breakpoint.c: "no memory" software watchpoints and enum casts Pedro Alves
2015-11-18 16:40 ` [PATCH 5/6] [C++] Drop -fpermissive hack Pedro Alves
2015-11-18 16:48 ` [PATCH 0/6] [C++] Drop -fpermissive hack, enable -Werror Simon Marchi
2015-11-18 16:49 ` [PATCH 6/6] [C++] Default to -Werror in C++ mode too Pedro Alves
2015-11-18 17:44 ` Yao Qi [this message]
2015-11-18 17:53   ` [PATCH 0/6] [C++] Drop -fpermissive hack, enable -Werror Pedro Alves
2015-11-19 11:28     ` Yao Qi
2015-11-19 15:14       ` Pedro Alves
2015-11-20  9:46         ` Yao Qi
2015-11-20 11:21           ` Pedro Alves
2015-11-24 11:01             ` Yao Qi
2015-11-24 13:17               ` Pedro Alves
2015-11-24 14:37                 ` Joel Brobecker
2015-11-24 13:19             ` Pedro Alves
2015-11-19 15:17       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564CB8EC.5000203@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox