From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112383 invoked by alias); 18 Nov 2015 16:48:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112312 invoked by uid 89); 18 Nov 2015 16:48:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 18 Nov 2015 16:48:06 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 9A.80.32596.8B94C465; Wed, 18 Nov 2015 10:49:44 +0100 (CET) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.248.2; Wed, 18 Nov 2015 11:48:03 -0500 Subject: Re: [PATCH 0/6] [C++] Drop -fpermissive hack, enable -Werror To: Pedro Alves , References: <1447864802-24016-1-git-send-email-palves@redhat.com> From: Simon Marchi Message-ID: <564CABC3.4030008@ericsson.com> Date: Wed, 18 Nov 2015 16:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447864802-24016-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00371.txt.bz2 On 15-11-18 11:39 AM, Pedro Alves wrote: > The first 4 patches finally make GDB build cleanly in C++, at least on > x86_64 GNU/Linux and x86_64 mingw. At this point, I think we should > drop the -fpermissive hack and default to -Werror in C++ mode too, > which is what the last two patches do. > > This lets the buildbot catch C++ build regressions promptly -- we > already have a Fedora buildslave building in C++ mode specifically for > that, but it currently misses regressions around pointer casts and > enum conversions exactly due to -fpermissive/-Wno-error. > > Other ports still need further C++ conversion work, though the build > failures shouldn't be too many and should be mostly localized to > host/target-specific code. > > Pedro Alves (5): > [C++] remote.c: Avoid enum arithmetic > [C++] linux-thread-db.c: dladdr cast > [C++] breakpoint.c: "no memory" software watchpoints and enum casts > [C++] Drop -fpermissive hack > [C++] Default to -Werror in C++ mode too > > Simon Marchi (1): > [C++] s390: Fix enum gdb_syscall conversion > > gdb/breakpoint.c | 49 ++++++++++++++++++++++++++++++++++------------ > gdb/build-with-cxx.m4 | 3 +-- > gdb/configure | 10 +++------- > gdb/configure.ac | 7 ++----- > gdb/gdbserver/configure | 6 ++---- > gdb/gdbserver/configure.ac | 3 +-- > gdb/linux-thread-db.c | 2 +- > gdb/remote.c | 2 +- > gdb/s390-linux-tdep.c | 41 ++++++++++++++++++++++---------------- > gdb/target.c | 36 +++++++++++++++++++++++----------- > gdb/target.h | 4 ++++ > 11 files changed, 100 insertions(+), 63 deletions(-) > This all looks good to me!