From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27760 invoked by alias); 17 Nov 2015 13:49:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27747 invoked by uid 89); 17 Nov 2015 13:49:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Nov 2015 13:49:38 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 9EF5F935F0; Tue, 17 Nov 2015 13:49:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAHDnaH2021839; Tue, 17 Nov 2015 08:49:36 -0500 Message-ID: <564B306F.1020301@redhat.com> Date: Tue, 17 Nov 2015 13:49:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Patrick Palka CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Type-safe wrapper for enum flags References: <1446144341-21267-1-git-send-email-palves@redhat.com> <563897E6.30006@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00339.txt.bz2 On 11/09/2015 01:24 PM, Patrick Palka wrote: > FWIW the latest patch looks good to me. Thanks. I've pushed the patch in now, along with Simon's follow up. > > BTW, I think GCC could make use of this enum_flags abstraction. When > GCC moved to C++ it seems to have went the type-unsafe route regarding > enum compatibility, converting "enum foo { ... };" to "enum foo_flags > { ... }; typedef int foo;" which is a pretty inferior solution. Do you > plan on incorporating this abstraction into GCC too? If not, I can > help to do it. Nope, I don't have plans for that. Feel free to run with it. Thanks, Pedro Alves