From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27737 invoked by alias); 16 Nov 2015 01:30:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27716 invoked by uid 89); 16 Nov 2015 01:30:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.8 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: heian.cn.fujitsu.com Received: from Unknown (HELO heian.cn.fujitsu.com) (59.151.112.132) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Nov 2015 01:30:07 +0000 Received: from unknown (HELO edo.cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 16 Nov 2015 09:29:44 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (localhost.localdomain [127.0.0.1]) by edo.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id tAG1TCUU025977; Mon, 16 Nov 2015 09:29:13 +0800 Received: from localhost.localdomain (10.167.226.91) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server id 14.3.181.6; Mon, 16 Nov 2015 09:29:54 +0800 Message-ID: <56493179.3080202@cn.fujitsu.com> Date: Mon, 16 Nov 2015 01:30:00 -0000 From: fj User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [PATCH 0/3] Add tesecases for examine/display/list References: <1446620987-4140-1-git-send-email-feij.fnst@cn.fujitsu.com> <20151104212111.GN4009@adacore.com> In-Reply-To: <20151104212111.GN4009@adacore.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00304.txt.bz2 On 11/05/2015 05:21 AM, Joel Brobecker wrote: >> These patches add testcases to test examine/display/list under different conditions: >> *examine address in different data types >> *display data in different types, enable/disable display >> *list with more options > > Thanks for providing new testcases, we can always use additional > testing! > > First, a few comments, before I delve into reviewing the patches? > > (1) The GDB project requires that the copyright to all changes > integrated by assigned to the FSF. Do you have a copyright > assignment on file with the FSF? I tried looking at the current > records, and did not find you. If you don't, then let me know, > and we'll start the paper work. > Hello, I haven't got that and could you tell me how to start that? > (2) I noticed that your emails were not following some of the guidelines > we have for patch submission. The guidelines should all be > explained at this page: > > https://sourceware.org/gdb/wiki/ContributionChecklist > > (3) For testcases, there is a "cookbook" that provides best practices. > > https://sourceware.org/gdb/wiki/GDBTestcaseCookbook > -- Thanks Fei Jie