Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: FYI: GDB 7.10.1 release still planned end of Nov
Date: Sat, 14 Nov 2015 00:23:00 -0000	[thread overview]
Message-ID: <56467ED6.9030104@codesourcery.com> (raw)
In-Reply-To: <20151112193849.GB4646@adacore.com>

On 11/12/2015 12:38 PM, Joel Brobecker wrote:

>    - For a fix that needs to be put on the branch, there must be
>      a PR. If not already existing, then it needs to be created at:
>
>      https://sourceware.org/bugzilla/
>
>      This PR should document in as much details as possible the issue.
>      You can also hyper-link discussions on gdb-patches.

OK, I have created PR 19245 for this.

> Regarding backporting a change, it's super easy:
>
>    1. Find the SHA1 of the fix you pushed to master; I usually use
>       something like "git log --author=[...] --grep=[...]
>
>       For instance, I did...
>
>       % git log --author=sandra --grep=strprefix
>
>       ... and got:
>
>       commit 26d56a939e9e54e09d46ea6e9678463ac344fa33
>       Author: Sandra Loosemore <sandra@codesourcery.com>
>       Date:   Tue Aug 18 10:29:54 2015 -0700
>
>           Fix mis-parsing of hex register numbers in 'T' stop replies.
>
>    2. Then, create a gdb-7.10-branch branch in your repository:
>
>          % git branch --track gdb-7.10-branch origin/gdb-7.10-branch
>
>       You can then cherry-pick the change to that branch:
>
>          % git checkout gdb-7.10-branch

I'm really confused.  At this point, "git log" shows that my patch is 
already present in the checkout as commit 
e13cbb569965ee3baca2ad4801eeb910c2b2f03f, dated Tue Aug 18.

>          % git cherry-pick 26d56a939e9e54e09d46ea6e9678463ac344fa33
>          [you will probably need to fix ChangeLog conflicts]

...and "git diff" after this step only shows ChangeLog conflicts and no 
code changes.

>       And once all is ready, then just push to the FSF repo:
>
>          % git push origin gdb-7.10-branch

Is there something different I need to do here, did I screw up something 
in the recipe above, or is the patch really already present on the 
branch and you and Pedro just lost track of it?

-Sandra


  reply	other threads:[~2015-11-14  0:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 19:36 Joel Brobecker
2015-10-28 19:46 ` Pedro Alves
2015-11-12 18:44   ` Joel Brobecker
2015-11-12 18:55     ` Sandra Loosemore
2015-11-12 19:38       ` Joel Brobecker
2015-11-14  0:23         ` Sandra Loosemore [this message]
2015-11-14  8:58           ` Andreas Schwab
2015-11-15 17:14           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56467ED6.9030104@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox