From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21911 invoked by alias); 13 Nov 2015 01:13:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21893 invoked by uid 89); 13 Nov 2015 01:13:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Nov 2015 01:13:05 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1Zx2vF-0006Ro-C2 from Don_Breazeal@mentor.com ; Thu, 12 Nov 2015 17:13:01 -0800 Received: from [172.30.1.225] (147.34.91.1) by svr-orw-fem-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 12 Nov 2015 17:13:01 -0800 Subject: Re: [PATCH 3/3] Target remote mode fork and exec docs To: Eli Zaretskii References: <1447290000-31393-1-git-send-email-donb@codesourcery.com> <1447290000-31393-2-git-send-email-donb@codesourcery.com> <83mvuji2p9.fsf@gnu.org> CC: "gdb-patches@sourceware.org" From: Don Breazeal Message-ID: <56453917.9090801@codesourcery.com> Date: Fri, 13 Nov 2015 01:13:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <83mvuji2p9.fsf@gnu.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00282.txt.bz2 On 11/12/2015 8:48 AM, Eli Zaretskii wrote: >> From: Don Breazeal >> Date: Wed, 11 Nov 2015 17:00:00 -0800 >> > >> +@table @asis >> + >> +@cindex remote debugging, detach and program exit >> +@item Result of detach or program exit >> + >> +@strong{target remote mode:} When the debugged program exits or you >> +detach from it, @value{GDBN} disconnects from the target. When using >> +@code{gdbserver}, @code{gdbserver} will exit. >> + >> +@strong{target extended-remote mode:} When the debugged program exits or > > This is OK, but the fact that "target extended-remote mode:" part that > begins a sentence doesn't start with a capital letter looks wrong. > How about starting with @strong{With target extended-remote mode:} > instead? >> +@item The @code{run} command >> +@strong{target remote mode:} The @code{run} command is not supported. > > Please be consistent regarding whether or not you leave an empty line > after the @item line. (My suggestion is not to leave such a line in a > @table.) Items above are now done in my sandbox. > >> If you're using a serial line, you may want to give @value{GDBN} the >> @samp{--baud} option, or use the @code{set serial baud} command >> (@pxref{Remote Configuration, set serial baud}) before the >> -@code{target} command. >> +@kbd{target} command. > > Here you show 2 commands in the same sentence, one with @code, the > other with @kbd. I think both should use @code. > >> +In @code{target extended-remote} mode, you can also attach using the >> +@value{GDBN} attach command >> +(@pxref{Types of Remote Connections: Attaching}). > > I don't understand this @pxref -- there's no such node or anchor in > the text. Does this work for you? (Also, using a colon in > cross-reference or node names is a bad idea, as that confuses Info > readers.) These last two I had fixed in my sandbox but apparently the fixes didn't make it into the patch I posted, sorry about that. :-S Regarding the @pxrefs that had colons in them, I have a question. I was making a cross-reference into the middle of a section, so there is no section heading to use as the name of the reference. I was trying to refer to "The part about Attaching that is in the section 'Types of Remote Connections'". How about: @anchor{Attaching in Types of Remote Connections} > > The patch is approved, assuming the above minor issues are fixed. > > Thanks. > Thanks again for the review and the suggestions. --Don