From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13381 invoked by alias); 28 Mar 2019 11:35:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13142 invoked by uid 89); 28 Mar 2019 11:35:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=UD:E, linuxlowc, HCC:D*ca, UD:linux-low.c X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr70055.outbound.protection.outlook.com (HELO EUR04-HE1-obe.outbound.protection.outlook.com) (40.107.7.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Mar 2019 11:35:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zbvyeKhSo4GudGUy1Rwg5tuEziSBplTTlbieIyprTR4=; b=XFvKjurgAuVNZ17o2M5lmt2mSkcwAf3zbgCmapcw6kwQ/SLQgoTbssxiOHt3h/zg+LVvmZNV0QsXvZ5vaAzR02tTZ/A5p/RDWUasd+a/DN0FpsX2PQnfCC2FV0aNdi7DcklI33l9D9miIMLap9edqadT6/FL2wUspAowK92+B1U= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2214.eurprd08.prod.outlook.com (10.172.226.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Thu, 28 Mar 2019 11:35:04 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::d122:4a29:4ae4:790c]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::d122:4a29:4ae4:790c%10]) with mapi id 15.20.1750.014; Thu, 28 Mar 2019 11:35:04 +0000 From: Alan Hayward To: Ulrich Weigand CC: Simon Marchi , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 2/2] gdbserver: Add linux_get_hwcap Date: Thu, 28 Mar 2019 11:35:00 -0000 Message-ID: <5644210E-638E-4EE9-924F-7A62B7A74E7C@arm.com> References: <20190328095036.A0EE1D802AE@oc3748833570.ibm.com> In-Reply-To: <20190328095036.A0EE1D802AE@oc3748833570.ibm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: <2CD5138CDC945E4497696242EAC493ED@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00704.txt.bz2 DQoNCj4gT24gMjggTWFyIDIwMTksIGF0IDA5OjUwLCBVbHJpY2ggV2VpZ2Fu ZCA8dXdlaWdhbmRAZGUuaWJtLmNvbT4gd3JvdGU6DQo+IA0KPiBBbGFuIEhh eXdhcmQgd3JvdGU6DQo+IA0KPj4gICAgICAgICAgICogbGludXgtbG93LmMg KGxpbnV4X2dldF9hdXh2KTogTmV3IGZ1bmN0aW9uLg0KPj4gICAgICAgICAg IChsaW51eF9nZXRfaHdjYXApOiBMaWtld2lzZS4NCj4+ICAgICAgICAgICAo bGludXhfZ2V0X2h3Y2FwMik6IExpa2V3aXNlLg0KPiANCj4gVGhpcyBzdGls bCBicmVha3MgdGhlIGJ1aWxkIG9uIG15IENlbGwvQi5FLiBkYWlseWJ1aWxk Og0KPiANCj4gZ2RiL2dkYnNlcnZlci9saW51eC1sb3cuYzogSW4gZnVuY3Rp b24gJ0NPUkVfQUREUiBsaW51eF9nZXRfaHdjYXAyKGludCknOg0KPiBnZGIv Z2Ric2VydmVyL2xpbnV4LWxvdy5jOjc0NzE6MzY6IGVycm9yOiAnQVRfSFdD QVAyJyB3YXMgbm90IGRlY2xhcmVkIGluIHRoaXMgc2NvcGUNCj4gICByZXR1 cm4gbGludXhfZ2V0X2F1eHYgKHdvcmRzaXplLCBBVF9IV0NBUDIpOw0KPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fg0K PiANCj4gVGhlIHN5c3RlbSAoUkhFTDUpIGlzIHNvIG9sZCB0aGF0IHRoZSBz eXN0ZW0gaGVhZGVycyBkbyBub3QNCj4geWV0IHByb3ZpZGUgQVRfSFdDQVAy LiAgVGhlIG9sZCBjb2RlIHdvcmtlZCBiZWNhdXNlDQo+IGxpbnV4LXBwYy1s b3cuYyBnb3QgdGhlIGRlZmluZSB2aWEgI2luY2x1ZGUgImVsZi9jb21tb24u aCIsDQo+IHdoaWNoIGxpbnV4LWxvdy5jIGRvZXMgbm90IGluY2x1ZGUuDQo+ IA0KDQpHYWghIEFub3RoZXIgZmFpbHVyZS4gQXBvbG9naWVzLg0KDQo+IEkg Z3Vlc3Mgd2Ugc2hvdWxkIGVpdGhlciBoYXZlIGxpbnV4LWxvdy5jIGluY2x1 ZGUgdGhlIGxvY2FsDQo+IGZpbGUgYXMgd2VsbCAoaWYgdGhhdCBpcyBwb3Nz aWJsZSAtLSB0aGVyZSBtYXkgYmUgY29uZmxpY3RzDQo+IHdpdGggPGVsZi5o PiB0aGF0IGlzIG90aGVyd2lzZSBhbHJlYWR5IGluY2x1ZGVkKSwgb3IgZWxz ZQ0KPiBwcm92aWRlIGEgZmFsbGJhY2sgZGVmaW5lIG9mIEFUX0hXQ0FQMiBv bmx5Lg0KDQpJ4oCZdmUganVzdCB0cmllZCBhZGRpbmcgdGhlIGluY2x1ZGUg YW5kIEkgZ2V0IGNvbmZsaWN0cy4NCg0KTGludXgtbG93IGFscmVhZHkgaGFz IHNvbWUgc2ltaWxhciBmYWxsYmFjayBkZWZpbmVzLCBlZzoNCg0KI2lmbmRl ZiBPX0xBUkdFRklMRQ0KI2RlZmluZSBPX0xBUkdFRklMRSAwDQojZW5kaWYN Cg0KSeKAmWxsIHNlbmQgb3V0IGEgbmV3IE9CViBwYXRjaCB3aXRoIHRoZSBB VF9IV0NBUDIgYWRkZWQgaW4gdGhlIHNhbWUgd2F5Lg0KDQoNCg0KQWxhbi4N Cg0KDQo+IA0KPiBCeWUsDQo+IFVscmljaA0KPiANCj4gLS0gDQo+ICBEci4g VWxyaWNoIFdlaWdhbmQNCj4gIEdOVS9MaW51eCBjb21waWxlcnMgYW5kIHRv b2xjaGFpbg0KPiAgVWxyaWNoLldlaWdhbmRAZGUuaWJtLmNvbQ0KPiANCg0K >From gdb-patches-return-155017-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Mar 28 11:39:35 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 36889 invoked by alias); 28 Mar 2019 11:39:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 36671 invoked by uid 89); 28 Mar 2019 11:39:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f49.google.com Received: from mail-wr1-f49.google.com (HELO mail-wr1-f49.google.com) (209.85.221.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Mar 2019 11:39:33 +0000 Received: by mail-wr1-f49.google.com with SMTP id g3so18973498wrx.9 for ; Thu, 28 Mar 2019 04:39:33 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id e12sm26568416wrt.94.2019.03.28.04.39.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 04:39:31 -0700 (PDT) Subject: Re: [patch, nios2] fix stepping past unwritable kernel helper To: Sandra Loosemore , "gdb-patches@sourceware.org" , qiyao@sourceware.org References: <80464f56-fccb-0bb4-dcdd-6a547e5418b0@codesourcery.com> From: Pedro Alves Message-ID: <25d33f77-a884-c214-5dbb-0d45863e5a75@redhat.com> Date: Thu, 28 Mar 2019 11:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <80464f56-fccb-0bb4-dcdd-6a547e5418b0@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00705.txt.bz2 Content-length: 336 On 03/28/2019 04:47 AM, Sandra Loosemore wrote: > +static int > +nios2_linux_is_kernel_helper (CORE_ADDR pc) > +{ > + return pc == 0x1004; > +} > + > + /* Returns true if PC points to a kernel helper function. */ > + int (*is_kernel_helper) (CORE_ADDR pc); Nit: please make these return bool instead of int. Thanks, Pedro Alves