From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80786 invoked by alias); 10 Nov 2015 19:08:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80777 invoked by uid 89); 10 Nov 2015 19:08:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Nov 2015 19:08:03 +0000 Received: from hogfather.0x04.net (89-65-84-110.dynamic.chello.pl [89.65.84.110]) by xyzzy.0x04.net (Postfix) with ESMTPS id 95C8F3FEBD; Tue, 10 Nov 2015 20:08:21 +0100 (CET) Received: from [192.168.13.108] (89-65-84-110.dynamic.chello.pl [89.65.84.110]) by hogfather.0x04.net (Postfix) with ESMTPSA id 36EA55800AC; Tue, 10 Nov 2015 20:08:01 +0100 (CET) Subject: Re: [PATCH v2 1/2] gdb/testsuite/gdb.trace: Deduplicate pcreg/spreg/fpreg. To: Yao Qi References: <1447154499-22247-1-git-send-email-koriakin@0x04.net> <1447155300-22660-1-git-send-email-koriakin@0x04.net> <86twotwxgb.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56424091.3090704@0x04.net> Date: Tue, 10 Nov 2015 19:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <86twotwxgb.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00263.txt.bz2 On 10/11/15 18:55, Yao Qi wrote: > Marcin Kościelnicki writes: > >> gdb/testsuite/ChangeLog: >> >> * gdb.trace/backtrace.exp: Use global fpreg/spreg definition, add $ >> in front. >> * gdb.trace/change-loc.exp: Use global pcreg definition. >> * gdb.trace/collection.exp: Use global pcreg/fpreg/spreg definition. >> * gdb.trace/entry-values.exp: Use global spreg definition, add $ >> in front. >> * gdb.trace/mi-trace-frame-collected.exp: Use global pcreg definition. >> * gdb.trace/pending.exp: Likewise. >> * gdb.trace/report.exp: Use global pcreg/fpreg/spreg definition. >> * gdb.trace/trace-break.exp: Likewise. >> * gdb.trace/trace-condition.exp: Use global pcreg definition, add $ >> in front. >> * gdb.trace/unavailable.exp: Use global pcreg/fpreg/spreg definition. >> * gdb.trace/while-dyn.exp: Use global fpreg definition, add $ >> in front. >> * lib/trace-support.exp: Define fpreg, spreg, pcreg variables. > > Looks good to me. Thanks. > Thanks, pushed. Any feedback on the second patch?