From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11536 invoked by alias); 5 Nov 2015 10:14:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11527 invoked by uid 89); 5 Nov 2015 10:14:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 05 Nov 2015 10:14:12 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 1F254473 for ; Thu, 5 Nov 2015 10:14:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA5AE9TT008477; Thu, 5 Nov 2015 05:14:10 -0500 Message-ID: <563B2BF1.2050007@redhat.com> Date: Thu, 05 Nov 2015 10:14:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Kevin Buettner , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.dwarf2: Define and use gdb_target_symbol_prefix for symbol prefixes References: <20151029212509.438b5642@pinnacle.lan> <56334F21.1020205@redhat.com> <20151104144908.320110e1@pinnacle.lan> In-Reply-To: <20151104144908.320110e1@pinnacle.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00176.txt.bz2 On 11/04/2015 09:49 PM, Kevin Buettner wrote: > On Fri, 30 Oct 2015 11:06:09 +0000 > Pedro Alves wrote: > >> On 10/30/2015 04:25 AM, Kevin Buettner wrote: >> >>> +# gdb_target_symbol_prefix compiles a test program and uses readelf >>> +# to determine the prefix (such as underscore) for linker symbol >>> +# prefixes. >>> + >>> +proc gdb_target_symbol_prefix {} { >> >> Shouldn't this be gdb_caching_proc ? > > Yes, it should. I've fixed this in my new patch. Thanks Kevin. This version generally looks good to me. Some comments below. > >> Then T wonder whether something like: >> >> - DW_OP_addr table_2_ptr >> + DW_OP_addr [gdb_symbol table_2_ptr] >> >> instead of prepending the $prefix variable results in clearer >> test code. > > I like this idea too. I used the name 'gdb_target_symbol' for this. > > Defining the obvious proc (for gdb_target_symbol) worked out of the > box for all cases except gdb.dwarf2/atomic-type.exp. For that I > needed to make a change to lib/dwarf.exp (and learned a bit more about > tcl in the process). If you know of a cleaner way to code it, let me > know - I couldn't think of a way to do it without adding the if-else > statement. Not sure I see what makes gdb.dwarf2/atomic-type.exp different? E.g., the gdb.dwarf2/dw2-bad-mips-linkage-name.exp hunk looks quite similar. What makes gdb.dwarf2/atomic-type.exp special? > With regard to gdb_target_symbol_prefix_flags, I think I'll change > it to call the new gdb_target_symbol_prefix. That seems preferable > to hardcoding a bunch of targets. If it all works out, I'll submit a > separate patch. Yes, please, that's the idea. :-) > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 048070b..e1c9839 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -5521,6 +5521,54 @@ proc core_find {binfile {deletefiles {}} {arg ""}} { > return $destcore > } > > +# gdb_target_symbol_prefix compiles a test program and uses readelf to s/readelf/objdump/ > +# determine the prefix (such as underscore) for linker symbol > +# prefixes. > + > +gdb_caching_proc gdb_target_symbol_prefix { > + # Set up and compile a simple test program... Thanks, Pedro Alves