From: fj <feij.fnst@cn.fujitsu.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/3] Add tesecases for examine/display/list
Date: Thu, 05 Nov 2015 08:02:00 -0000 [thread overview]
Message-ID: <563B0CE0.9080907@cn.fujitsu.com> (raw)
In-Reply-To: <20151104212111.GN4009@adacore.com>
On 11/05/2015 05:21 AM, Joel Brobecker wrote:
>> These patches add testcases to test examine/display/list under different conditions:
>> *examine address in different data types
>> *display data in different types, enable/disable display
>> *list with more options
>
> Thanks for providing new testcases, we can always use additional
> testing!
>
> First, a few comments, before I delve into reviewing the patches?
>
> (1) The GDB project requires that the copyright to all changes
> integrated by assigned to the FSF. Do you have a copyright
> assignment on file with the FSF? I tried looking at the current
> records, and did not find you. If you don't, then let me know,
> and we'll start the paper work.
>
I haven't got a copyright assignment on file with the FSF yet.
> (2) I noticed that your emails were not following some of the guidelines
> we have for patch submission. The guidelines should all be
> explained at this page:
>
> https://sourceware.org/gdb/wiki/ContributionChecklist
>
> (3) For testcases, there is a "cookbook" that provides best practices.
>
> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook
>
OK. I will remake my patches basing on these.
--
Thanks
Fei Jie
next prev parent reply other threads:[~2015-11-05 8:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 7:10 Fei Jie
2015-11-04 7:10 ` [PATCH 1/3] Add testcases for examine function Fei Jie
2015-11-04 21:30 ` Joel Brobecker
2015-11-04 21:37 ` Andrew Burgess
2015-11-04 7:10 ` [PATCH 3/3] Add testcases for list function Fei Jie
2015-11-04 21:42 ` Joel Brobecker
2015-11-04 7:10 ` [PATCH 2/3] Add testcases for display function Fei Jie
2015-11-04 21:39 ` Joel Brobecker
2015-11-04 21:21 ` [PATCH 0/3] Add tesecases for examine/display/list Joel Brobecker
2015-11-05 8:02 ` fj [this message]
2015-11-16 1:30 ` fj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563B0CE0.9080907@cn.fujitsu.com \
--to=feij.fnst@cn.fujitsu.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox