From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110064 invoked by alias); 4 Nov 2015 18:58:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110052 invoked by uid 89); 4 Nov 2015 18:58:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Nov 2015 18:58:53 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id C83EB8F4F3; Wed, 4 Nov 2015 18:58:51 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA4IwopC023646; Wed, 4 Nov 2015 13:58:51 -0500 Message-ID: <563A556A.7080808@redhat.com> Date: Wed, 04 Nov 2015 18:58:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH 10/10] Enable conditional breakpoints for targets that support software single step in GDBServer. References: <1446138583-13268-1-git-send-email-antoine.tremblay@ericsson.com> <1446138583-13268-11-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1446138583-13268-11-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00156.txt.bz2 On 10/29/2015 05:09 PM, Antoine Tremblay wrote: > > - if (target_supports_hardware_single_step ()) > + if (target_supports_hardware_single_step () || > + target_supports_software_single_step () ) || on the next line. Otherwise LGTM. Thanks, Pedro Alves