From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77066 invoked by alias); 4 Nov 2015 18:46:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77035 invoked by uid 89); 4 Nov 2015 18:46:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Nov 2015 18:46:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id CADDEA8A; Wed, 4 Nov 2015 18:46:50 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA4IknS6011611; Wed, 4 Nov 2015 13:46:50 -0500 Message-ID: <563A5298.7000104@redhat.com> Date: Wed, 04 Nov 2015 18:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH 08/10] Support software single step on ARM in GDBServer. References: <1446138583-13268-1-git-send-email-antoine.tremblay@ericsson.com> <1446138583-13268-9-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1446138583-13268-9-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00152.txt.bz2 On 10/29/2015 05:09 PM, Antoine Tremblay wrote: > This patch teaches GDBserver how to software single step on ARM > linux by sharing code with GDB. > > The arm_get_next_pcs function in GDB is now shared with GDBServer. So that > GDBServer can use the function to return the possible addresses of the next PC. > > A proper shared context was also needed so that we could share the code, this > context is described as this data structure (expressed as a class > hierarchy): > > struct get_next_pcs > struct os_arch_get_next_pcs > struct os_arch_(gdb|gdbserver)_get_next_pcs > > Where arch can by replaced by arm for this patch. This structure should be > flexible enough to accomodate any arch or os (optional) that would need a > get_next_pcs context. Thanks for following through with this. I skimmed this and it looks very much like what I had imagined, so LGTM from a general design perspective. But I'd rather leave it to Yao to go over the ARM details. (BTW, I noticed several formatting problems just from skimming. I'd be good if you did a pass over the patch fixing them; I'm sure you'll notice them too.) Thanks, Pedro Alves