From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102460 invoked by alias); 3 Nov 2015 17:05:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102435 invoked by uid 89); 3 Nov 2015 17:05:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 03 Nov 2015 17:05:00 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 5C.01.26730.5DB78365; Tue, 3 Nov 2015 10:18:13 +0100 (CET) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.86) with Microsoft SMTP Server id 14.3.248.2; Tue, 3 Nov 2015 12:04:57 -0500 Subject: Re: [PATCH 01/10] Fix breakpoint size when stepping over a permanent breakpoint in GDBServer. To: Yao Qi References: <1446138583-13268-1-git-send-email-antoine.tremblay@ericsson.com> <1446138583-13268-2-git-send-email-antoine.tremblay@ericsson.com> <861tc7yrx9.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <5638E936.6000100@ericsson.com> Date: Tue, 03 Nov 2015 17:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <861tc7yrx9.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00117.txt.bz2 On 11/03/2015 11:21 AM, Yao Qi wrote: > Antoine Tremblay writes: > >> static int >> -arm_breakpoint_at (CORE_ADDR where) >> +arm_is_thumb_mode (void) >> { > > Please add comments to arm_is_thumb_mode. Fixed as : /* Returns 1 if the current instruction set is thumb, 0 otherwise. */ > >> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h >> index 769c876..f0fb9d7 100644 >> --- a/gdb/gdbserver/target.h >> +++ b/gdb/gdbserver/target.h >> @@ -451,6 +451,12 @@ struct target_ops >> specific meaning like the Z0 kind parameter. >> SIZE is set to the software breakpoint's length in memory. */ >> const gdb_byte *(*sw_breakpoint_from_kind) (int kind, int *size); >> + >> + /* Return the breakpoint kind for this target based on the current state > > Maybe "current machine state" or "current processor state" is better > than "current state"? Agreed. set as "current processor state" > >> + (e.g. the current instruction mode on ARM) and the PC. The PCPTR is > > Two spaces before "The PCPTR". Fixed. > >> + adjusted to the real memory location in case a flag (e.g., the Thumb >> + bit on ARM) was present in the PC. */ > > "is present in the PC." ? > Fixed, thanks.