From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13190 invoked by alias); 3 Nov 2015 16:44:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13173 invoked by uid 89); 3 Nov 2015 16:44:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Nov 2015 16:44:22 +0000 Received: from hogfather.0x04.net (89-65-84-110.dynamic.chello.pl [89.65.84.110]) by xyzzy.0x04.net (Postfix) with ESMTPS id ED45A3FEE2; Tue, 3 Nov 2015 17:44:37 +0100 (CET) Received: from [192.168.1.35] (84-10-2-59.static.chello.pl [84.10.2.59]) by hogfather.0x04.net (Postfix) with ESMTPSA id BAC55580092; Tue, 3 Nov 2015 17:44:19 +0100 (CET) Subject: Re: [PATCH v3 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit. To: Ulrich Weigand References: <20151103161321.7F0C92665@oc7340732750.ibm.com> Cc: gdb-patches@sourceware.org From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <5638E463.5040601@0x04.net> Date: Tue, 03 Nov 2015 16:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151103161321.7F0C92665@oc7340732750.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2015-11/txt/msg00113.txt.bz2 On 03/11/15 17:13, Ulrich Weigand wrote: > Marcin KoÅcielnicki wrote: > >> gdb/ChangeLog: >> >> PR/18376 >> * gdb/s390-linux-tdep.c (s390_is_partial_instruction): New function. >> (s390_software_single_step): New function. >> (s390_displaced_step_hw_singlestep): New function. >> (s390_gdbarch_init): Fill gdbarch slots with the above. > >> + /* Special handling only if recording. */ >> + if (!record_full_is_used()) >> + return 0; >> + >> + /* First, match a partial instruction. */ >> + if (!s390_is_partial_instruction(gdbarch, loc, &len)) >> + return 0; > > Coding style issue: space before ( for function calls. > > Patch is OK with that change. > > Thanks, > Ulrich > Thanks for the review. Should I push these two patches already, or wait for review on the xmalloc one first? [https://sourceware.org/ml/gdb-patches/2015-11/msg00021.html]