From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84110 invoked by alias); 3 Nov 2015 16:12:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84101 invoked by uid 89); 3 Nov 2015 16:12:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 03 Nov 2015 16:12:33 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id E9A60AA0BF; Tue, 3 Nov 2015 16:12:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA3GCUZt011381; Tue, 3 Nov 2015 11:12:30 -0500 Message-ID: <5638DCED.2090305@redhat.com> Date: Tue, 03 Nov 2015 16:12:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org CC: Simon Marchi Subject: Re: [PATCH c++ 03/12] remote-sim.c: Add casts References: <1446560804-18858-1-git-send-email-simon.marchi@ericsson.com> <1446560804-18858-3-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1446560804-18858-3-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00101.txt.bz2 On 11/03/2015 02:26 PM, Simon Marchi wrote: > From: Simon Marchi > > Mostly some casts from "generic arg" void* to the actual type. > > There are two (enum gdb_signal) casts. I tried to see if it would have > been better to change the type of sigrc, but it has a double role, as an > enum and as an integer, so I left it as is. I think the sim's sim_stop_reason 'int *sigrc' parameter should be adjusted to gdb_signal* instead of int*. AFAICS, the sims do write a gdb_signal to it. (And if they didn't, it would look like a bug to me). > > gdb/ChangeLog: > > * remote-sim.c (check_for_duplicate_sim_descriptor): Add casts. > (get_sim_inferior_data): Likewise. > (sim_inferior_data_cleanup): Likewise. > (gdbsim_close_inferior): Likewise. > (gdbsim_resume_inferior): Likewise. > (gdbsim_wait): Likewise. > (simulator_command): Likewise. > (sim_command_completer): Likewise. In any case, this is OK. We can fix the sim some other day. Thanks, Pedro Alves