From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27256 invoked by alias); 3 Nov 2015 16:06:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27244 invoked by uid 89); 3 Nov 2015 16:06:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 03 Nov 2015 16:05:55 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 861B4AC1A1; Tue, 3 Nov 2015 16:05:54 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA3G5qlt001814; Tue, 3 Nov 2015 11:05:53 -0500 Message-ID: <5638DB60.7060200@redhat.com> Date: Tue, 03 Nov 2015 16:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org CC: Simon Marchi Subject: Re: [PATCH c++ 01/12] linux-ppc-low.c: Remove forward declaration, move ppc_arch_setup lower References: <1446560804-18858-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1446560804-18858-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-11/txt/msg00099.txt.bz2 On 11/03/2015 02:26 PM, Simon Marchi wrote: > From: Simon Marchi > > g++ doesn't like that we forward-declare a variable that is initialized > later in the file. It's easy enough to re-order things to fix it. Yeah, doesn't work in C either with -fno-common. > > Fixes > > /home/simark/src/binutils-gdb/gdb/gdbserver/linux-ppc-low.c:663:28: error: redefinition of ‘usrregs_info ppc_usrregs_info’ > static struct usrregs_info ppc_usrregs_info = > ^ > /home/simark/src/binutils-gdb/gdb/gdbserver/linux-ppc-low.c:381:28: note: ‘usrregs_info ppc_usrregs_info’ previously declared here > static struct usrregs_info ppc_usrregs_info; > ^ > > gdb/gdbserver/ChangeLog: > > * linux-ppc-low.c (ppc_usrregs_info): Remove > forward-declaration. > (ppc_arch_setup): Move lower in file. OK. Thanks, Pedro Alves