From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79395 invoked by alias); 3 Nov 2015 14:07:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79309 invoked by uid 89); 3 Nov 2015 14:07:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 03 Nov 2015 14:07:00 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 069E4C10044E; Tue, 3 Nov 2015 14:06:59 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA3E6vul013063; Tue, 3 Nov 2015 09:06:58 -0500 Message-ID: <5638BF81.5070705@redhat.com> Date: Tue, 03 Nov 2015 14:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 07/11] [C++/mingw] Define __STDC_CONSTANT_MACROS / __STDC_LIMIT_MACROS for stdint.h References: <1446492970-21432-1-git-send-email-palves@redhat.com> <1446492970-21432-8-git-send-email-palves@redhat.com> <5637CBC9.2050404@ericsson.com> <5638BD73.8000706@ericsson.com> In-Reply-To: <5638BD73.8000706@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00082.txt.bz2 On 11/03/2015 01:58 PM, Simon Marchi wrote: > On 15-11-02 03:47 PM, Simon Marchi wrote: >> FYI, I stumbled on the same problem when building for various architectures this weekend. I >> generated some toolchains by using some of the Buildroot included configurations, which use >> uclibc. I ended up defining those macros as well in CFLAGS. So that change can help for more >> configurations than just mingw. > > Actually, would it be better to add ifndefs? > > #ifndef __STDC_CONSTANT_MACROS > #define __STDC_CONSTANT_MACROS > #endif > > (same for __STDC_LIMIT_MACROS) > > I tried to build the latest version of the branch, but since I had specified those in CFLAGS, I get: Isn't this a case of "don't do that (CFLAGS), then" ? If I update the gnulib patch per Paul's comment here: https://lists.nongnu.org/archive/html/bug-gnulib/2015-11/msg00006.html then __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS will be unconditionally defined in config.h; I don't think defines in config.h can be ifndefed. Thanks, Pedro Alves