From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89849 invoked by alias); 3 Nov 2015 11:48:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89835 invoked by uid 89); 3 Nov 2015 11:48:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 03 Nov 2015 11:48:18 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 39A6E19F384; Tue, 3 Nov 2015 11:48:17 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA3BmFmq005090; Tue, 3 Nov 2015 06:48:16 -0500 Message-ID: <56389EFF.2000606@redhat.com> Date: Tue, 03 Nov 2015 11:48:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Doug Evans CC: gdb-patches Subject: Re: [PATCH] Type-safe wrapper for enum flags References: <1446144341-21267-1-git-send-email-palves@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-11/txt/msg00066.txt.bz2 On 11/01/2015 02:06 AM, Doug Evans wrote: > On Thu, Oct 29, 2015 at 11:45 AM, Pedro Alves wrote: >> This patch fixes C++ build errors like this: >> >> /home/pedro/gdb/mygit/cxx-convertion/src/gdb/linux-tdep.c:1126:35: error: invalid conversion from ‘int’ to ‘filterflags’ [-fpermissive] >> | COREFILTER_HUGETLB_PRIVATE); >> ^ >> ... >> --- >> gdb/btrace.h | 10 +- >> gdb/c-exp.y | 5 +- >> gdb/common/enum_flags.h | 211 +++++++++++++++++++++++++++++++++++++++++ >> gdb/compile/compile-c-types.c | 2 +- >> gdb/compile/compile-internal.h | 4 + >> gdb/completer.c | 5 +- >> gdb/disasm.c | 4 +- >> gdb/infrun.c | 14 +-- >> gdb/linux-tdep.c | 19 ++-- >> gdb/record-btrace.c | 22 +++-- >> gdb/record.h | 2 + >> gdb/source.c | 7 +- >> gdb/symtab.h | 6 +- > > Nit. > > Introducing a foo_bar file when every other file in the patch uses > foo-bar is a bit odd. > > enum-flags.h? > Not sure about that. The currently file name simply follows the class name "class enum_flags". AFAICS, we have other files with _ in the name for that reason, like gdb_flags.h and gdb_signals.h. Other examples are gdb wrappers for some external header or functionality, like gdb_bfd.h, gdb_expat.h, gdb_regex.h, etc. Thanks, Pedro Alves