From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18840 invoked by alias); 2 Nov 2015 20:55:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18712 invoked by uid 89); 2 Nov 2015 20:55:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 Nov 2015 20:55:29 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id F2A968E706; Mon, 2 Nov 2015 20:55:27 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA2KtQZM014753; Mon, 2 Nov 2015 15:55:27 -0500 Message-ID: <5637CDBE.40703@redhat.com> Date: Mon, 02 Nov 2015 20:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 06/11] [C++/mingw] ser-tcp.c casts References: <1446492970-21432-1-git-send-email-palves@redhat.com> <1446492970-21432-7-git-send-email-palves@redhat.com> <5637CA30.4080200@ericsson.com> In-Reply-To: <5637CA30.4080200@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-11/txt/msg00051.txt.bz2 On 11/02/2015 08:40 PM, Simon Marchi wrote: > On 15-11-02 02:36 PM, Pedro Alves wrote: >> Fixes a few errors like these: >> >> ../../src/gdb/ser-tcp.c: In function 'int net_open(serial*, const char*)': >> ../../src/gdb/ser-tcp.c:286:73: error: invalid conversion from 'void*' to 'char*' [-fpermissive] >> res = getsockopt (scb->fd, SOL_SOCKET, SO_ERROR, (void *) &err, &len); >> ^ >> >> gdb/ChangeLog: >> 2015-11-01 Pedro Alves >> >> * ser-tcp.c (net_open) [USE_WIN32API]: Cast getsockopt argument to >> char * instead of void *. >> (net_read_prim): Cast recv argument to >> char * instead of void *. >> (net_write_prim): Cast send argument to char * instead of void *. >> --- >> gdb/ser-tcp.c | 19 +++++++++++++------ >> 1 file changed, 13 insertions(+), 6 deletions(-) >> >> diff --git a/gdb/ser-tcp.c b/gdb/ser-tcp.c >> index ce40b61..507e0a1 100644 >> --- a/gdb/ser-tcp.c >> +++ b/gdb/ser-tcp.c >> @@ -280,10 +280,12 @@ net_open (struct serial *scb, const char *name) >> >> len = sizeof (err); >> /* On Windows, the fourth parameter to getsockopt is a "char *"; >> - on UNIX systems it is generally "void *". The cast to "void *" >> - is OK everywhere, since in C "void *" can be implicitly >> - converted to any pointer type. */ >> + on UNIX systems it is generally "void *". */ >> +#ifdef USE_WIN32API >> + res = getsockopt (scb->fd, SOL_SOCKET, SO_ERROR, (char *) &err, &len); >> +#else >> res = getsockopt (scb->fd, SOL_SOCKET, SO_ERROR, (void *) &err, &len); >> +#endif > > You could have done exactly the opposite of the old comment, that is cast to > (char *). It shouldn't generate any warning in either case. But I think that > your way is fine too. Oh, good point. I always forget that implicit cast to void* works. I'll update the patch. Thanks, Pedro Alves