From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79006 invoked by alias); 2 Nov 2015 19:59:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78989 invoked by uid 89); 2 Nov 2015 19:59:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 Nov 2015 19:59:48 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 4B9378F31A; Mon, 2 Nov 2015 19:59:47 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA2JxjvB026219; Mon, 2 Nov 2015 14:59:46 -0500 Message-ID: <5637C0B1.7060402@redhat.com> Date: Mon, 02 Nov 2015 19:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb/reverse: Fix continue_to_breakpoint in syscall testcases. References: <5637B6C0.8060500@redhat.com> <1446494319-5810-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1446494319-5810-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-11/txt/msg00041.txt.bz2 On 11/02/2015 07:58 PM, Marcin Kościelnicki wrote: > continue_to_breakpoint always continues to the next breakpoint, not to the > one named in parameter. This rendered the tests effectively useless, since > marker2 was never reached. > > gdb/testsuite/ChangeLog: > > * gdb.reverse/fstatat-reverse.exp: Set breakpoint on marker1 after > reaching marker2. > * gdb.reverse/getresuid-reverse.exp: Likewise. > * gdb.reverse/pipe-reverse.exp: Likewise. > * gdb.reverse/readv-reverse.exp: Likewise. > * gdb.reverse/recvmsg-reverse.exp: Likewise. > * gdb.reverse/time-reverse.exp: Likewise. > * gdb.reverse/waitpid-reverse.exp: Likewise and add KFAILs. OK. Thanks! -- Pedro Alves