From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89411 invoked by alias); 2 Nov 2015 19:17:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89400 invoked by uid 89); 2 Nov 2015 19:17:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 Nov 2015 19:17:25 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 4AECC8535A; Mon, 2 Nov 2015 19:17:24 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA2JHKnn009728; Mon, 2 Nov 2015 14:17:21 -0500 Message-ID: <5637B6C0.8060500@redhat.com> Date: Mon, 02 Nov 2015 19:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/reverse: Fix continue_to_breakpoint in syscall testcases. References: <563791E6.9010200@redhat.com> <1446490031-3226-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1446490031-3226-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-11/txt/msg00025.txt.bz2 On 11/02/2015 06:47 PM, Marcin Kościelnicki wrote: > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,13 @@ > +2015-11-02 Marcin Kościelnicki > + > + * gdb.reverse/fstatat-reverse.exp: Fix continue_to_breakpoint. > + * gdb.reverse/getresuid-reverse.exp: Fix continue_to_breakpoint. > + * gdb.reverse/pipe-reverse.exp: Fix continue_to_breakpoint. > + * gdb.reverse/readv-reverse.exp: Fix continue_to_breakpoint and comment. > + * gdb.reverse/recvmsg-reverse.exp: Fix continue_to_breakpoint. > + * gdb.reverse/time-reverse.exp: Fix continue_to_breakpoint. > + * gdb.reverse/waitpid-reverse.exp: Fix continue_to_breakpoint, add KFAILs. Boring nit: In ChangeLog files, it's preferred to say "what" changed. E.g., "Continue to marker1 before continuing to marker2". > diff --git a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp > index 09deb6c..39401dc 100644 > --- a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp > +++ b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp > @@ -44,6 +44,8 @@ gdb_test "break marker2" \ > "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ > "set breakpoint at marker2" > > +gdb_continue_to_breakpoint "marker1" ".*$srcfile:.*" > + > gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" Did you try running to marker2 first, and _then_ create the marker1 breakpoint? gdb_test "break marker1" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker1" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" That is, just move the gdb_continue_to_breakpoint earlier. That would avoid the double continue, which was what I pointed out originally. > diff --git a/gdb/testsuite/gdb.reverse/readv-reverse.exp b/gdb/testsuite/gdb.reverse/readv-reverse.exp > index 4158c10..a98ded5 100644 > --- a/gdb/testsuite/gdb.reverse/readv-reverse.exp > +++ b/gdb/testsuite/gdb.reverse/readv-reverse.exp > @@ -16,7 +16,7 @@ > # This file is part of the gdb testsuite. > > # > -# This test tests pipe syscall for reverse execution. > +# This test tests readv syscall for reverse execution. > # > Please split this hunk to a separate patch and push it in as a typo fix. Thanks, Pedro Alves