From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67330 invoked by alias); 2 Nov 2015 16:40:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67316 invoked by uid 89); 2 Nov 2015 16:40:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 Nov 2015 16:40:12 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id ED72842E5A9; Mon, 2 Nov 2015 16:40:09 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA2Ge63h017173; Mon, 2 Nov 2015 11:40:07 -0500 Message-ID: <563791E6.9010200@redhat.com> Date: Mon, 02 Nov 2015 16:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= , qiyaoltc@gmail.com CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 01/13] gdb/linux-record: Add testcases for a few syscalls. References: <5628E5D6.5020706@0x04.net> <1445521166-14492-1-git-send-email-koriakin@0x04.net> <5632035E.30809@redhat.com> <56327421.6090203@0x04.net> <5633486B.40502@redhat.com> <5636BD98.2090401@0x04.net> In-Reply-To: <5636BD98.2090401@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-11/txt/msg00012.txt.bz2 On 11/02/2015 01:34 AM, Marcin Kościelnicki wrote: > Well, this is embarassing... > > Turns out gdb_continue_to_breakpoint doesn't care all that much about > the name of the breakpoint passed in as the first parameter, it just > happily continues to the next breakpoint, whatever it happens to be. > > So the testcases as commited never actually make it to marker2, and they > all trivially pass (state when reaching marker1 is, after all, exactly > identical to reaching marker2 and then correctly reversing to marker1). > > I should've known that stepping over fork suddenly starting to work was > too good to be true. Whoops, sorry for missing that too. > > So... can I get that push access now and fix my mess, or do I no longer > qualify as having submitted a good patch due to the above? :) :-) See "I need an account" at https://sourceware.org/. Say I approved it. Once you have that sorted, add yourself to the "Write After Approval" section in gdb/MAINTAINERS, push that change to the repo (no need for approval on that one), and post that commit on the list. Thanks, Pedro Alves