From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129126 invoked by alias); 30 Oct 2015 15:44:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129113 invoked by uid 89); 30 Oct 2015 15:44:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 30 Oct 2015 15:44:47 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 832E7157748; Fri, 30 Oct 2015 15:44:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9UFijSr031179; Fri, 30 Oct 2015 11:44:45 -0400 Message-ID: <5633906C.5070700@redhat.com> Date: Sat, 31 Oct 2015 20:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Type-safe wrapper for enum flags References: <1446144341-21267-1-git-send-email-palves@redhat.com> <56337B95.6070809@ericsson.com> <56338435.6080703@redhat.com> <56338FA1.2060300@ericsson.com> In-Reply-To: <56338FA1.2060300@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00767.txt.bz2 On 10/30/2015 03:41 PM, Simon Marchi wrote: > On 15-10-30 10:52 AM, Pedro Alves wrote: >> Looks like c-lang.h should include common/enum_flags.h. > > Good point. Include What You Use. It should be included in the .h file, IMO. Otherwise, if anything includes c-lang.h that doesn't happen to pull in enum_flags.h already, it'll break. > >> Otherwise LGTM. >> >> I'd like to collect at least one Ack on the enum flags patch >> before pushing it. > > Here is the patch with the include. When it's time to push your patch, > can you make this one follow? Sure thing. I'll put it in the C++ branch meanwhile. I'll take care of the moving the include. Thanks, Pedro Alves