From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113827 invoked by alias); 30 Oct 2015 11:06:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113816 invoked by uid 89); 30 Oct 2015 11:06:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 30 Oct 2015 11:06:12 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 4B7BFC0B2E2F for ; Fri, 30 Oct 2015 11:06:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9UB69AP002813; Fri, 30 Oct 2015 07:06:10 -0400 Message-ID: <56334F21.1020205@redhat.com> Date: Fri, 30 Oct 2015 15:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Kevin Buettner , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.dwarf2: Define and use gdb_target_symbol_prefix for symbol prefixes References: <20151029212509.438b5642@pinnacle.lan> In-Reply-To: <20151029212509.438b5642@pinnacle.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00757.txt.bz2 On 10/30/2015 04:25 AM, Kevin Buettner wrote: > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 048070b..f8e35ac 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -5521,6 +5521,45 @@ proc core_find {binfile {deletefiles {}} {arg ""}} { > return $destcore > } > > +# gdb_target_symbol_prefix compiles a test program and uses readelf > +# to determine the prefix (such as underscore) for linker symbol > +# prefixes. > + > +proc gdb_target_symbol_prefix {} { Shouldn't this be gdb_caching_proc ? Then T wonder whether something like: - DW_OP_addr table_2_ptr + DW_OP_addr [gdb_symbol table_2_ptr] instead of prepending the $prefix variable results in clearer test code. > + set readelf_program [gdb_find_readelf] > + set result [catch "exec $readelf_program --syms $exe" output] > + > + if { $result == 0 \ > + && ![regexp { ([^ a-zA-Z0-9]*)main$} $output dummy prefix] } { > + verbose "gdb_target_symbol_prefix: Could not find main in readelf output; returning null prefix" 2 > + } I'm wondering about using a method that would work for mingw/cygwin as well. The only existing use of the target symbol prefix in the tree is for those targets, which are coff/pe, not elf. See gdb_target_symbol_prefix_flags. Maybe just use objdump instead? Thanks, Pedro Alves