Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH] guile/: Add enum casts
Date: Thu, 29 Oct 2015 17:51:00 -0000	[thread overview]
Message-ID: <5632592D.3070000@redhat.com> (raw)
In-Reply-To: <1446058487-22472-1-git-send-email-palves@redhat.com>

On 10/28/2015 06:54 PM, Pedro Alves wrote:
> In both cases the casts looks appropriate to me.  In the
> gdbscm_disasm_memory_error case, the status is marshaled through the
> opcodes disassemble interface.  In the
> gdbscm_unwind_stop_reason_string case, the int comes from Guile.
> 
> gdb/ChangeLog:
> 2015-10-28  Pedro Alves  <palves@redhat.com>
> 
> 	* guile/scm-disasm.c (gdbscm_disasm_memory_error): Add cast.
> 	* guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Add cast.

I split out the second hunk and pushed it in as an obvious change.

--------
From: Pedro Alves <palves@redhat.com>
Subject: [PATCH] guile/: Add enum cast

gdb/ChangeLog:
2015-10-29  Pedro Alves  <palves@redhat.com>

	* guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Add cast.
---
 gdb/ChangeLog         | 4 ++++
 gdb/guile/scm-frame.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 000566e..9433221 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2015-10-29  Pedro Alves  <palves@redhat.com>
+
+	* guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Add cast.
+
 2015-10-29  Eli Zaretskii  <eliz@gnu.org>
 
 	* utils.c (init_page_info): Disable paging if INSIDE_EMACS is set
diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c
index 24e26e8..55e0faf 100644
--- a/gdb/guile/scm-frame.c
+++ b/gdb/guile/scm-frame.c
@@ -1045,7 +1045,7 @@ gdbscm_unwind_stop_reason_string (SCM reason_scm)
   if (reason < UNWIND_FIRST || reason > UNWIND_LAST)
     scm_out_of_range (FUNC_NAME, reason_scm);
 
-  str = unwind_stop_reason_to_string (reason);
+  str = unwind_stop_reason_to_string ((enum unwind_stop_reason) reason);
   return gdbscm_scm_from_c_string (str);
 }
 \f
-- 
1.9.3



      parent reply	other threads:[~2015-10-29 17:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 12:31 Pedro Alves
2015-10-29 12:43 ` Simon Marchi
2015-10-29 13:00   ` Pedro Alves
2015-10-29 13:02     ` Pedro Alves
2015-10-29 13:02       ` Pedro Alves
2015-11-17 13:47         ` Pedro Alves
2015-10-29 17:51 ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5632592D.3070000@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox