From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-127154-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30478 invoked by alias); 29 Oct 2015 17:16:11 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30376 invoked by uid 89); 29 Oct 2015 17:16:10 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 29 Oct 2015 17:16:06 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (Postfix) with ESMTPS id 715D0A37D2;	Thu, 29 Oct 2015 17:16:04 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9THFrED025934;	Thu, 29 Oct 2015 13:15:57 -0400
Message-ID: <56325447.1090905@redhat.com>
Date: Thu, 29 Oct 2015 17:50:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH c++ 6/6] Add a cast in jit_target_read_impl
References: <1446123767-25046-1-git-send-email-simon.marchi@polymtl.ca> <1446123767-25046-7-git-send-email-simon.marchi@polymtl.ca>
In-Reply-To: <1446123767-25046-7-git-send-email-simon.marchi@polymtl.ca>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-10/txt/msg00718.txt.bz2

On 10/29/2015 01:02 PM, Simon Marchi wrote:
> We could change the signature of the function.  However, it would
> require changing gdb_target_read in jit-reader.h, which is an exported
> interface.  It's probably better to just add a cast in our code than to
> break other people's code.

Agreed.

> 
> gdb/ChangeLog:
> 
> 	* jit.c (jit_target_read_impl): Add cast.

OK.

Thanks,
Pedro Alves