From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59899 invoked by alias); 28 Oct 2015 17:10:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59889 invoked by uid 89); 28 Oct 2015 17:10:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 28 Oct 2015 17:10:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id B5C6EC0AEE32; Wed, 28 Oct 2015 17:10:09 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9SHA8r8029503; Wed, 28 Oct 2015 13:10:08 -0400 Message-ID: <56310170.1090607@redhat.com> Date: Wed, 28 Oct 2015 19:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Add missing leading space to some queries References: <1446049232-2318-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1446049232-2318-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00660.txt.bz2 On 10/28/2015 04:20 PM, Patrick Palka wrote: > Query strings should have a leading space so that there is some kind of > separator between the actual query and the "(y or n)" suffix that is > appended to the query. > OK. Though, it would seem better to me to go the other way around and have query() itself add the space. E.g. the way it is, translations would need to know that the space is there to keep, which seems fragile. Thanks, Pedro Alves