From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21189 invoked by alias); 27 Oct 2015 13:36:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21180 invoked by uid 89); 27 Oct 2015 13:36:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qk0-f171.google.com Received: from mail-qk0-f171.google.com (HELO mail-qk0-f171.google.com) (209.85.220.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 27 Oct 2015 13:36:55 +0000 Received: by qkgb2 with SMTP id b2so461865qkg.0 for ; Tue, 27 Oct 2015 06:36:53 -0700 (PDT) X-Received: by 10.55.51.200 with SMTP id z191mr50372987qkz.21.1445953013731; Tue, 27 Oct 2015 06:36:53 -0700 (PDT) Received: from [10.0.0.136] (modemcable053.173-58-74.mc.videotron.ca. [74.58.173.53]) by smtp.gmail.com with ESMTPSA id f66sm15139831qkf.33.2015.10.27.06.36.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2015 06:36:53 -0700 (PDT) Subject: Re: [PATCH c++ 01/12] Introduce ax_raw_byte and use it To: Pedro Alves , gdb-patches@sourceware.org References: <1445831204-16588-1-git-send-email-simon.marchi@polymtl.ca> <562F6B02.60605@redhat.com> From: Simon Marchi Message-ID: <562F7DF3.3060001@polymtl.ca> Date: Tue, 27 Oct 2015 16:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <562F6B02.60605@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00622.txt.bz2 On 27/10/15 08:16 AM, Pedro Alves wrote: > On 10/26/2015 03:46 AM, Simon Marchi wrote: >> This patch was taken directly from Pedro's branch. >> > > Thanks. > >> ax_simple is used to append an agent expression operator to an agent >> expression string. Therefore, it takes an enum agent_op as input. >> There is an instance where it's called to append a raw byte, unrelated >> to the enum. It makes the build fail in C++ mode. >> >> This patch introduces ax_raw_byte for that purpose and uses it. >> >> gdb/ChangeLog: >> >> * ax.h (ax_raw_byte): New declaration. >> * ax-general.c (ax_raw_byte): New function. >> (ax_simple): Use ax_raw_byte. >> * ax-gdb.c (gen_printf): Likewise. > > OK. > > Thanks, > Pedro Alves > Pushed thanks.