From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH c++ 12/12] ada-lang.h: Add cast in GROW_VECT
Date: Tue, 27 Oct 2015 16:00:00 -0000 [thread overview]
Message-ID: <562F7C58.8090504@polymtl.ca> (raw)
In-Reply-To: <562F6A5B.7020500@redhat.com>
On 27/10/15 08:13 AM, Pedro Alves wrote:
> It's certainly fine with me.
>
> Thanks,
> Pedro Alves
Ok, pushed.
From a480de357b17b1b2057b8375284079ccafae39db Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@polymtl.ca>
Date: Tue, 27 Oct 2015 09:27:40 -0400
Subject: [PATCH] ada-lang.h: Add cast in GROW_VECT
The assignment requires a cast in C++. We only use this macro for
vectors of chars, so adding (char *) diretly will do for now.
gdb/ChangeLog:
* ada-lang.h (GROW_VECT): Add cast.
---
gdb/ChangeLog | 4 ++++
gdb/ada-lang.h | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 27ea4f6..7b78890 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2015-10-27 Simon Marchi <simon.marchi@polymtl.ca>
+
+ * ada-lang.h (GROW_VECT): Add cast.
+
2015-10-26 Doug Evans <xdje42@gmail.com>
* symtab.h (struct general_symbol_info> <ada_mangled>: Update comment.
diff --git a/gdb/ada-lang.h b/gdb/ada-lang.h
index 62896f1..7c527cc 100644
--- a/gdb/ada-lang.h
+++ b/gdb/ada-lang.h
@@ -147,7 +147,7 @@ struct ada_task_info
least M objects, updating V and S as necessary. */
#define GROW_VECT(v, s, m) \
- if ((s) < (m)) (v) = grow_vect (v, &(s), m, sizeof *(v));
+ if ((s) < (m)) (v) = (char *) grow_vect (v, &(s), m, sizeof *(v));
extern void *grow_vect (void *, size_t *, size_t, int);
--
2.6.1
next prev parent reply other threads:[~2015-10-27 13:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 10:23 [PATCH c++ 11/12] target.c: Add a cast and change a type Simon Marchi
2015-10-26 10:38 ` [PATCH c++ 12/12] ada-lang.h: Add cast in GROW_VECT Simon Marchi
2015-10-26 23:09 ` Pedro Alves
2015-10-27 9:54 ` Simon Marchi
2015-10-27 14:55 ` Pedro Alves
2015-10-27 16:00 ` Simon Marchi [this message]
2015-10-27 9:54 ` [PATCH c++ 11/12] target.c: Add a cast and change a type Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F7C58.8090504@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox