From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125184 invoked by alias); 27 Oct 2015 12:16:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125173 invoked by uid 89); 27 Oct 2015 12:16:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 27 Oct 2015 12:16:04 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id C61F08E249; Tue, 27 Oct 2015 12:16:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9RCG21d029821; Tue, 27 Oct 2015 08:16:03 -0400 Message-ID: <562F6B02.60605@redhat.com> Date: Tue, 27 Oct 2015 15:08:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH c++ 01/12] Introduce ax_raw_byte and use it References: <1445831204-16588-1-git-send-email-simon.marchi@polymtl.ca> In-Reply-To: <1445831204-16588-1-git-send-email-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00616.txt.bz2 On 10/26/2015 03:46 AM, Simon Marchi wrote: > This patch was taken directly from Pedro's branch. > Thanks. > ax_simple is used to append an agent expression operator to an agent > expression string. Therefore, it takes an enum agent_op as input. > There is an instance where it's called to append a raw byte, unrelated > to the enum. It makes the build fail in C++ mode. > > This patch introduces ax_raw_byte for that purpose and uses it. > > gdb/ChangeLog: > > * ax.h (ax_raw_byte): New declaration. > * ax-general.c (ax_raw_byte): New function. > (ax_simple): Use ax_raw_byte. > * ax-gdb.c (gen_printf): Likewise. OK. Thanks, Pedro Alves