From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12883 invoked by alias); 23 Oct 2015 15:05:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12867 invoked by uid 89); 23 Oct 2015 15:05:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 23 Oct 2015 15:05:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 021C52EA; Fri, 23 Oct 2015 15:05:04 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9NF53mX022482; Fri, 23 Oct 2015 11:05:04 -0400 Message-ID: <562A4C9F.9000404@redhat.com> Date: Fri, 23 Oct 2015 23:56:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Fix nto, spu and win32 builds of GDBServer. References: <1445543917-16839-1-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1445543917-16839-1-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00502.txt.bz2 On 10/22/2015 08:58 PM, Antoine Tremblay wrote: > Fix nto, spu and win32 builds of GDBServer. > > This patch series fixes the build that was broken by : > https://sourceware.org/ml/gdb-patches/2015-10/msg00369.html > > 1st patch refactors default_breakpoint_kind to make this easier. > > 2nd patch fixes nto,spu and win32 builds. > > 3rd patch is cleaning up the set_breakpoint_data definition. This all looks good to me. > I tested win32 with mingw but could not test nto and spu, if anyone > can test it's apreciated ? I think it doesn't hurt to put it in immediately. Even if extra tweaking is necessary for those targets, it won't be worse than the current state. Thanks, Pedro Alves