From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.base/ending-run.exp on manjaro linux
Date: Thu, 28 Mar 2024 08:27:08 +0100 [thread overview]
Message-ID: <5629753d-b5ca-4123-b0a9-d72e061c2d0f@suse.de> (raw)
In-Reply-To: <20240314095710.23415-1-tdevries@suse.de>
On 3/14/24 10:57, Tom de Vries wrote:
> On aarch64-linux, using the manjaro linux distro, I run into:
> ...
> (gdb) next^M
> 32 }^M
> (gdb) next^M
> 0x0000fffff7d67b80 in ?? () from /usr/lib/libc.so.6^M
> (gdb) FAIL: gdb.base/ending-run.exp: step out of main
> ...
>
> What happens here is described in detail in this clause:
> ...
> -re "0x.*\\?\\? \\(\\) from /lib/powerpc.*$gdb_prompt $" {
> # This case occurs on Powerpc when gdb steps out of main and the
> # needed debug info files are not loaded on the system, preventing
> # GDB to determine which function it reached (__libc_start_call_main).
> # Ideally, the target system would have the necessary debugging
> # information, but in its absence, GDB's behavior is as expected.
> ...
> }
> ...
> but the clause only matches for powerpc.
>
> Fix this by:
> - making the regexp generic enough to also match /usr/lib/libc.so.6, and
> - updating the comment to not mention powerpc.
>
> Tested on aarch64-linux.
>
Pushed.
Thanks,
- Tom
> PR testsuite/31450
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31450
> ---
> gdb/testsuite/gdb.base/ending-run.exp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.base/ending-run.exp b/gdb/testsuite/gdb.base/ending-run.exp
> index 9c80de6879b..b9a72b0e70e 100644
> --- a/gdb/testsuite/gdb.base/ending-run.exp
> +++ b/gdb/testsuite/gdb.base/ending-run.exp
> @@ -206,8 +206,8 @@ gdb_test_multiple "next" "step out of main" {
> # This is what happens on system using uClibc.
> pass "step out of main"
> }
> - -re "0x.*\\?\\? \\(\\) from /lib/powerpc.*$gdb_prompt $" {
> - # This case occurs on Powerpc when gdb steps out of main and the
> + -re -wrap "$hex in \\?\\? \\(\\) from \[^\r\n\]+" {
> + # This case occurs when gdb steps out of main and the
> # needed debug info files are not loaded on the system, preventing
> # GDB to determine which function it reached (__libc_start_call_main).
> # Ideally, the target system would have the necessary debugging
>
> base-commit: 2618e5f141c89c15f5b13fd0b79312f1bc723bc9
prev parent reply other threads:[~2024-03-28 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 9:57 Tom de Vries
2024-03-28 7:27 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5629753d-b5ca-4123-b0a9-d72e061c2d0f@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox