From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11584 invoked by alias); 22 Oct 2015 16:26:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11570 invoked by uid 89); 22 Oct 2015 16:26:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 22 Oct 2015 16:26:13 +0000 Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id B1.43.32596.B7DA8265; Thu, 22 Oct 2015 11:33:47 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.92) with Microsoft SMTP Server id 14.3.248.2; Thu, 22 Oct 2015 12:26:09 -0400 Subject: Re: [PATCH v2] Fix inconsistent breakpoint kinds between breakpoints and tracepoints in GDBServer. To: Pedro Alves References: <5628FE0C.5090309@redhat.com> <1445529414-11581-1-git-send-email-antoine.tremblay@ericsson.com> <5629079A.3050809@redhat.com> <562908C6.4010903@ericsson.com> <56290915.9060608@redhat.com> <56290999.9070103@ericsson.com> <56290AB6.5050308@redhat.com> <56290BE8.5080401@ericsson.com> <56290C4E.4050208@ericsson.com> <56290D67.6080100@redhat.com> CC: GDB From: Antoine Tremblay Message-ID: <56290E21.3020200@ericsson.com> Date: Fri, 23 Oct 2015 15:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56290D67.6080100@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00492.txt.bz2 On 10/22/2015 12:23 PM, Pedro Alves wrote: > On 10/22/2015 05:18 PM, Antoine Tremblay wrote: >> >> >> On 10/22/2015 12:16 PM, Antoine Tremblay wrote: >>> >>> >>> On 10/22/2015 12:11 PM, Pedro Alves wrote: > >>>> You don't need this one nor the equivalent in other ports if you >>>> add this to target.h: >>>> >>>> #define target_breakpoint_kind_from_pc(PCPTR) \ >>>> (the_target->breakpoint_kind_from_pc \ >>>> ? (*the_target->breakpoint_kind_from_pc) (PCPTR) \ >>>> : default_breakpoint_kind_from_pc ()) >>>> >>>> (see the other similar macros there) >>>> >>>> You'll need to adjust callers to call target_breakpoint_kind_from_pc >>>> instead, of course. >>>> >>> > >>> Yes but then I would need a os_arch_sw_breakpoint_from_kind operation in >>> all the arch that this os supports (and that I can't test), you think >>> it's still better that way ? >>> >> >> Unless I have another macro that checks for the sw_breakpoint_from_kind >> and if abscent returns breakpoint_len... I could do that I guess.. > > I guess I'm confused. Why doesn't what you already had, like > below, work as is? > > static const gdb_byte * > win32_sw_breakpoint_from_kind (int kind, int *size) > { > *size = the_low_target.breakpoint_len; > return the_low_target.breakpoint; > } > Ho yes it would, sorry I was confused I though you meant remove both win32_breakpoint_kind_from_pc and win32_sw_breakpoint_from_kind before. Removing only win32_breakpoint_kind_from_pc and adding the default macro works. Thanks, Antoine