From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120298 invoked by alias); 22 Oct 2015 16:23:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119998 invoked by uid 89); 22 Oct 2015 16:23:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 Oct 2015 16:23:06 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 03402C0A846C; Thu, 22 Oct 2015 16:23:05 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9MGN37x015308; Thu, 22 Oct 2015 12:23:04 -0400 Message-ID: <56290D67.6080100@redhat.com> Date: Fri, 23 Oct 2015 08:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay CC: GDB Subject: Re: [PATCH v2] Fix inconsistent breakpoint kinds between breakpoints and tracepoints in GDBServer. References: <5628FE0C.5090309@redhat.com> <1445529414-11581-1-git-send-email-antoine.tremblay@ericsson.com> <5629079A.3050809@redhat.com> <562908C6.4010903@ericsson.com> <56290915.9060608@redhat.com> <56290999.9070103@ericsson.com> <56290AB6.5050308@redhat.com> <56290BE8.5080401@ericsson.com> <56290C4E.4050208@ericsson.com> In-Reply-To: <56290C4E.4050208@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00491.txt.bz2 On 10/22/2015 05:18 PM, Antoine Tremblay wrote: > > > On 10/22/2015 12:16 PM, Antoine Tremblay wrote: >> >> >> On 10/22/2015 12:11 PM, Pedro Alves wrote: >>> You don't need this one nor the equivalent in other ports if you >>> add this to target.h: >>> >>> #define target_breakpoint_kind_from_pc(PCPTR) \ >>> (the_target->breakpoint_kind_from_pc \ >>> ? (*the_target->breakpoint_kind_from_pc) (PCPTR) \ >>> : default_breakpoint_kind_from_pc ()) >>> >>> (see the other similar macros there) >>> >>> You'll need to adjust callers to call target_breakpoint_kind_from_pc >>> instead, of course. >>> >> >> Yes but then I would need a os_arch_sw_breakpoint_from_kind operation in >> all the arch that this os supports (and that I can't test), you think >> it's still better that way ? >> > > Unless I have another macro that checks for the sw_breakpoint_from_kind > and if abscent returns breakpoint_len... I could do that I guess.. I guess I'm confused. Why doesn't what you already had, like below, work as is? static const gdb_byte * win32_sw_breakpoint_from_kind (int kind, int *size) { *size = the_low_target.breakpoint_len; return the_low_target.breakpoint; } Thanks, Pedro Alves