From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6488 invoked by alias); 22 Oct 2015 16:04:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6226 invoked by uid 89); 22 Oct 2015 16:04:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 Oct 2015 16:04:40 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id D11D791341; Thu, 22 Oct 2015 16:04:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9MG4bnl001028; Thu, 22 Oct 2015 12:04:38 -0400 Message-ID: <56290915.9060608@redhat.com> Date: Thu, 22 Oct 2015 19:58:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay CC: GDB Subject: Re: [PATCH v2] Fix inconsistent breakpoint kinds between breakpoints and tracepoints in GDBServer. References: <5628FE0C.5090309@redhat.com> <1445529414-11581-1-git-send-email-antoine.tremblay@ericsson.com> <5629079A.3050809@redhat.com> <562908C6.4010903@ericsson.com> In-Reply-To: <562908C6.4010903@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00485.txt.bz2 On 10/22/2015 05:03 PM, Antoine Tremblay wrote: > > > On 10/22/2015 11:58 AM, Pedro Alves wrote: >> On 10/22/2015 04:56 PM, Antoine Tremblay wrote: >>> This patch fixes a regression introduced by : >>> https://sourceware.org/ml/gdb-patches/2015-10/msg00369.html >>> >>> Tests : gdb.trace/trace-break.exp and gdb.trace/trace-mt.exp would fail on x86 >>> with gdbserver-{native,extended}. >>> >>> Before this patch, the breakpoint kind set by GDB with a Z packet and the one >>> set in the case of a tracepoint would be inconsistent on targets that did not >>> implement breakpoint_kind_from_pc. On x86 for example a breakpoint set by GDB >>> would have a kind of 1 but a breakpoint set by a tracepoint would have a kind of >>> 0. >>> >>> This created a missmatch when trying to insert a tracepoint and a breakpoint at >>> the same location. One of the two breakpoints would be removed with debug >>> message : "Inconsistent breakpoint kind". >>> >>> This patch fixes the issue by changing the default 0 breakpoint kind to be >>> the size of the breakpoint according to sw_breakpoint_from_kind. >>> >>> The default breakpoint kind must be the breakpoint length to keep consistency >>> between breakpoints set via GDB and the ones set internally by GDBServer. >>> >>> No regression on Ubuntu 14.04 x86-64 with gdbserver-{native-extended} >>> >>> gdb/gdbserver/ChangeLog: >>> >>> * linux-low.c (default_breakpoint_kind_from_pc): New function. >>> (linux_breakpoint_kind_from_pc): Use default_breakpoint_kind_from_pc for >>> the default breakpoint kind. >> >> OK. >> > > I forgot to set the function default_breakpoint_kind_from_pc static, ok > with that change ? Sure. (I think you'll need to move the function to target.c to fix !Linux ports, but I'm OK with doing that as a separate step.) Thanks, Pedro Alves