From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7435 invoked by alias); 22 Oct 2015 15:17:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7424 invoked by uid 89); 22 Oct 2015 15:17:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 Oct 2015 15:17:35 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 8DAD3344F71; Thu, 22 Oct 2015 15:17:34 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9MFHWRV013236; Thu, 22 Oct 2015 11:17:33 -0400 Message-ID: <5628FE0C.5090309@redhat.com> Date: Thu, 22 Oct 2015 16:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix inconsistent breakpoint kinds between breakpoints and tracepoints in GDBServer. References: <1445526373-6168-1-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1445526373-6168-1-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00477.txt.bz2 On 10/22/2015 04:06 PM, Antoine Tremblay wrote: > This patch fixes a regression introduced by : > https://sourceware.org/ml/gdb-patches/2015-10/msg00369.html > > Tests : gdb.trace/trace-break.exp and gdb.trace/trace-mt.exp would fail on x86 > with gdbserver-{native,extended}. > > Before this patch, the breakpoint kind set by GDB with a Z packet and the one > set in the case of a tracepoint would be inconsistent on targets that did not > implement breakpoint_kind_from_pc. On x86 for example a breakpoint set by GDB > would have a kind of 1 but a breakpoint set by a tracepoint would have a kind of > 0. Bummer. :-/ But, wouldn't it work to make the default be instead: int default_breakpoint_kind_from_pc (CORE_ADDR *pcptr) { int size; target_sw_breakpoint_from_kind (0, &size); return size; } ? Thanks, Pedro Alves