From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75773 invoked by alias); 22 Oct 2015 10:54:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75764 invoked by uid 89); 22 Oct 2015 10:54:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 Oct 2015 10:54:34 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 72D1D8E23F; Thu, 22 Oct 2015 10:54:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9MAsVoF008257; Thu, 22 Oct 2015 06:54:32 -0400 Message-ID: <5628C067.9040707@redhat.com> Date: Thu, 22 Oct 2015 13:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH c++ 4/5] mips: fix void*/gdb_byte* compilation errors References: <1444538238-7468-1-git-send-email-simon.marchi@polymtl.ca> <1444538238-7468-4-git-send-email-simon.marchi@polymtl.ca> In-Reply-To: <1444538238-7468-4-git-send-email-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00442.txt.bz2 On 10/11/2015 05:37 AM, Simon Marchi wrote: > The error in mips64_linux_get_longjmp_target is fixed by changing "buf" > to be a gdb_byte*, as usual. supply_32bit_reg and mips64_fill_gregset > do some more complicated things however, so it's safer just to add the > explicit cast and avoid changing the code too much. > > gdb/ChangeLog: > > * mips-linux-tdep.c (mips64_linux_get_longjmp_target): Change type of > buf to gdb_byte*. > (supply_32bit_reg): Add cast. > (mips64_fill_gregset): Likewise. OK. Thanks, Pedro Alves