From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71318 invoked by alias); 21 Oct 2015 18:44:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71260 invoked by uid 89); 21 Oct 2015 18:44:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 21 Oct 2015 18:44:32 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 6C.B8.32596.27C77265; Wed, 21 Oct 2015 13:52:18 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Wed, 21 Oct 2015 14:44:28 -0400 Subject: Re: [PATCH c++ 1/5] lm32: Add (const gdb_byte *) cast To: References: <1444538238-7468-1-git-send-email-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: <5627DD0C.8060908@ericsson.com> Date: Thu, 22 Oct 2015 09:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444538238-7468-1-git-send-email-simon.marchi@polymtl.ca> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00427.txt.bz2 On 15-10-11 12:37 AM, Simon Marchi wrote: > There might be a cleaner sequence of function calls to do what is done > here (I don't know), but since I don't want to risk breaking anything, > it's safer to just add the required cast. > > gdb/ChangeLog: > > * lm32-tdep.c (lm32_push_dummy_call): Add cast. > --- > gdb/lm32-tdep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/lm32-tdep.c b/gdb/lm32-tdep.c > index 25a7e1e..a0defad 100644 > --- a/gdb/lm32-tdep.c > +++ b/gdb/lm32-tdep.c > @@ -289,7 +289,7 @@ lm32_push_dummy_call (struct gdbarch *gdbarch, struct value *function, > regcache_cooked_write_unsigned (regcache, first_arg_reg + i, val); > else > { > - write_memory (sp, (void *) &val, TYPE_LENGTH (arg_type)); > + write_memory (sp, (const gdb_byte *) &val, TYPE_LENGTH (arg_type)); > sp -= 4; > } > } > Ping for patches 1 and 4.