From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17764 invoked by alias); 21 Oct 2015 16:13:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17689 invoked by uid 89); 21 Oct 2015 16:13:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Oct 2015 16:13:24 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Zow0v-00004X-IJ from Sandra_Loosemore@mentor.com for gdb-patches@sourceware.org; Wed, 21 Oct 2015 09:13:21 -0700 Received: from [IPv6:::1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.224.2; Wed, 21 Oct 2015 09:13:20 -0700 Message-ID: <5627B95B.9040907@codesourcery.com> Date: Wed, 21 Oct 2015 19:41:00 -0000 From: Sandra Loosemore User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: gdb-patches Subject: [patch, testsuite] adjust timeout in gdb.base/freebpcmd.exp Content-Type: multipart/mixed; boundary="------------060709060108010500020905" X-SW-Source: 2015-10/txt/msg00421.txt.bz2 --------------060709060108010500020905 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 450 I've been observing random failures in gdb.base/freebpcmd.exp on a bare-metal target using RSP with a slow debug probe. It seems that the hardwired timeout of 120 seconds for this test is just a little too low for this target. It seems better to use with_timeout_factor instead of a hardwired value; choosing a factor of 10 here is totally random, but it seems to be plenty on this target (its default timeout is 60). OK to commit? -Sandra --------------060709060108010500020905 Content-Type: text/x-log; name="gdb-freebpcmd.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="gdb-freebpcmd.log" Content-length: 162 2015-10-21 Sandra Loosemore gdb/testsuite/ * gdb.base/freebpcmd.exp: Use with_timeout_factor instead of hardwired timeout value. --------------060709060108010500020905 Content-Type: text/x-patch; name="gdb-freebpcmd.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="gdb-freebpcmd.patch" Content-length: 1359 diff --git a/gdb/testsuite/gdb.base/freebpcmd.exp b/gdb/testsuite/gdb.base/freebpcmd.exp index 2f46bc8..c7c0814 100644 --- a/gdb/testsuite/gdb.base/freebpcmd.exp +++ b/gdb/testsuite/gdb.base/freebpcmd.exp @@ -103,22 +103,19 @@ if {$i >= [llength $lines]} { gdb_run_cmd -set prev_timeout $timeout -set timeout 120 - -gdb_test_multiple "" "run program with breakpoint commands" { - -re "warning: Invalid control type in command structure" { - kfail "gdb/1489" "run program with breakpoint commands" - } - -re "Invalid i value\r\n$gdb_prompt $" { - xfail "run program with breakpoint commands (i value not readable)" - } - -re "$gdb_prompt $" { - pass "run program with breakpoint commands" - } - eof { - kfail "gdb/1489" "run program with breakpoint commands (GDB died)" +with_timeout_factor 10 { + gdb_test_multiple "" "run program with breakpoint commands" { + -re "warning: Invalid control type in command structure" { + kfail "gdb/1489" "run program with breakpoint commands" + } + -re "Invalid i value\r\n$gdb_prompt $" { + xfail "run program with breakpoint commands (i value not readable)" + } + -re "$gdb_prompt $" { + pass "run program with breakpoint commands" + } + eof { + kfail "gdb/1489" "run program with breakpoint commands (GDB died)" + } } } - -set timeout $prev_timeout --------------060709060108010500020905--