From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126849-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31177 invoked by alias); 21 Oct 2015 14:23:24 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 31164 invoked by uid 89); 21 Oct 2015 14:23:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 21 Oct 2015 14:23:23 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (Postfix) with ESMTPS id DD0C8C0A1461;	Wed, 21 Oct 2015 14:23:21 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9LENKKa012285;	Wed, 21 Oct 2015 10:23:21 -0400
Message-ID: <56279FD8.8010204@redhat.com>
Date: Wed, 21 Oct 2015 16:39:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Aleksandar Ristovski <aristovski@qnx.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] [nto] Improve ABI sniffing.
References: <5621218D.6070801@redhat.com> <1445364649-12175-1-git-send-email-aristovski@qnx.com> <1445364649-12175-3-git-send-email-aristovski@qnx.com> <56275FB2.3050509@redhat.com> <5627944D.3050900@qnx.com> <56279777.5060807@redhat.com> <56279EF9.2020200@qnx.com>
In-Reply-To: <56279EF9.2020200@qnx.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-10/txt/msg00413.txt.bz2

On 10/21/2015 03:14 PM, Aleksandar Ristovski wrote:
> +      name = note + sizeof_Elf_Nhdr;
> +      if (sectsize < namelen + sizeof_Elf_Nhdr
> +	  || namelen > sizeof (QNX_NOTE_NAME))
> +	{
> +	  /* Can not be QNX note.  */
> +	  XDELETEVEC (note);
> +	  return;
> +	}
> +
> +      if (namelen == sizeof (QNX_NOTE_NAME)
> +	  && 0 == strcmp (name, QNX_NOTE_NAME))
> +        *(enum gdb_osabi *) obj = GDB_OSABI_QNXNTO;
> +
> +      XDELETEVEC (note);

Looks like these two ifs are now the same as the simpler:

      name = note + sizeof_Elf_Nhdr;
      if (sectsize >= namelen + sizeof_Elf_Nhdr
          && namelen == sizeof (QNX_NOTE_NAME)
	  && 0 == strcmp (name, QNX_NOTE_NAME))
        *(enum gdb_osabi *) obj = GDB_OSABI_QNXNTO;

      XDELETEVEC (note);

OK with that change.

Thanks,
Pedro Alves