From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46485 invoked by alias); 21 Oct 2015 13:47:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46472 invoked by uid 89); 21 Oct 2015 13:47:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 21 Oct 2015 13:47:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id BF087CDF; Wed, 21 Oct 2015 13:47:36 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9LDlZUb015658; Wed, 21 Oct 2015 09:47:35 -0400 Message-ID: <56279777.5060807@redhat.com> Date: Wed, 21 Oct 2015 15:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Aleksandar Ristovski , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] [nto] Improve ABI sniffing. References: <5621218D.6070801@redhat.com> <1445364649-12175-1-git-send-email-aristovski@qnx.com> <1445364649-12175-3-git-send-email-aristovski@qnx.com> <56275FB2.3050509@redhat.com> <5627944D.3050900@qnx.com> In-Reply-To: <5627944D.3050900@qnx.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00410.txt.bz2 On 10/21/2015 02:34 PM, Aleksandar Ristovski wrote: > +static void > +nto_sniff_abi_note_section (bfd *abfd, asection *sect, void *obj) > +{ > + const char *sectname; > + unsigned int sectsize; > + /* Buffer holding the section contents. */ > + char *note; > + unsigned int namelen; > + const char *name; > + > + sectname = bfd_get_section_name (abfd, sect); > + sectsize = bfd_section_size (abfd, sect); > + > + if (sectsize > 128) > + sectsize = 128; > + > + if (sectname != NULL && strstr (sectname, QNX_INFO_SECT_NAME) != NULL) > + *(enum gdb_osabi *) obj = GDB_OSABI_QNXNTO; > + > + if (sectname != NULL && strstr (sectname, "note") != NULL) This can be "else if". > + { > + const unsigned sizeof_Elf_Nhdr = 12; > + > + note = XNEWVEC (char, sectsize); > + bfd_get_section_contents (abfd, sect, note, 0, sectsize); > + namelen = (unsigned int) bfd_h_get_32 (abfd, note); You also need to check that the section's size is enough to contain 'namelen', _before_ extracting it, otherwise you may be reading garbage. > + name = note + sizeof_Elf_Nhdr; > + if (sectsize < namelen + sizeof_Elf_Nhdr > + || namelen > sizeof (QNX_NOTE_NAME) + 1) > + { > + /* Can not be QNX note. */ > + XDELETEVEC (note); > + return; Thanks, Pedro Alves