From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22973 invoked by alias); 21 Oct 2015 13:04:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22071 invoked by uid 89); 21 Oct 2015 13:04:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 21 Oct 2015 13:04:13 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id E1DF82EA; Wed, 21 Oct 2015 13:04:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9LD4Aop001632; Wed, 21 Oct 2015 09:04:11 -0400 Message-ID: <56278D4A.4010102@redhat.com> Date: Wed, 21 Oct 2015 14:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH v3 2/5] Support breakpoint kinds for software breakpoints in GDBServer. References: <1445359685-2589-1-git-send-email-antoine.tremblay@ericsson.com> <1445359685-2589-3-git-send-email-antoine.tremblay@ericsson.com> <5627749B.1080805@redhat.com> <56277F2C.9040404@ericsson.com> In-Reply-To: <56277F2C.9040404@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00406.txt.bz2 On 10/21/2015 01:03 PM, Antoine Tremblay wrote: > > >> This comment should be expanded. Something like: >> >> /* The software breakpoint's kind. This is target specific. >> Most architectures only use one specific instruction for software >> breakpoints, while others may use more than one. E.g., on ARM, we >> need to set different breakpoint instructions on Thumb, Thumb-2, >> and ARM code. */ >> int kind; >> > > I will remove the "software" specification since hardware breakpoints > have kinds too encoded in this struct see for example : > arm_linux_hw_point_initialize. > > Like so : > > /* The breakpoint's kind. This is target specific. Most > architectures only use one specific instruction for breakpoints, while > others may use more than one. E.g., on ARM, we need to set different > breakpoint instructions on Thumb, Thumb-2, and ARM code. */ > Ah. Hmm, but if we only remove the "software" word and continue only talking about "instructions", then I think it ends up the same. How about extending it like this: /* The breakpoint's kind. This is target specific. Most architectures only use one specific instruction for breakpoints, while others may use more than one. E.g., on ARM, we need to use different breakpoint instructions on Thumb, Thumb-2, and ARM code. Likewise for hardware breakpoints -- some architectures (including ARM) need to setup debug registers differently depending on mode. */ Thanks, Pedro Alves