From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53122 invoked by alias); 21 Oct 2015 12:04:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53103 invoked by uid 89); 21 Oct 2015 12:04:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 21 Oct 2015 12:03:59 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 30.20.32596.59E17265; Wed, 21 Oct 2015 07:11:49 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.248.2; Wed, 21 Oct 2015 08:03:56 -0400 Subject: Re: [PATCH v3 2/5] Support breakpoint kinds for software breakpoints in GDBServer. To: Pedro Alves , References: <1445359685-2589-1-git-send-email-antoine.tremblay@ericsson.com> <1445359685-2589-3-git-send-email-antoine.tremblay@ericsson.com> <5627749B.1080805@redhat.com> From: Antoine Tremblay Message-ID: <56277F2C.9040404@ericsson.com> Date: Wed, 21 Oct 2015 14:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5627749B.1080805@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00405.txt.bz2 > This comment should be expanded. Something like: > > /* The software breakpoint's kind. This is target specific. > Most architectures only use one specific instruction for software > breakpoints, while others may use more than one. E.g., on ARM, we > need to set different breakpoint instructions on Thumb, Thumb-2, > and ARM code. */ > int kind; > I will remove the "software" specification since hardware breakpoints have kinds too encoded in this struct see for example : arm_linux_hw_point_initialize. Like so : /* The breakpoint's kind. This is target specific. Most architectures only use one specific instruction for breakpoints, while others may use more than one. E.g., on ARM, we need to set different breakpoint instructions on Thumb, Thumb-2, and ARM code. */