From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97680 invoked by alias); 21 Oct 2015 11:22:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97669 invoked by uid 89); 21 Oct 2015 11:22:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 21 Oct 2015 11:22:13 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 73A0B8C1A3; Wed, 21 Oct 2015 11:22:12 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9LBMBEZ005539; Wed, 21 Oct 2015 07:22:11 -0400 Message-ID: <56277562.6090603@redhat.com> Date: Wed, 21 Oct 2015 13:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH v3 0/5] Software breakpoints support for ARM linux in GDBServer. References: <1445359685-2589-1-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1445359685-2589-1-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00403.txt.bz2 On 10/20/2015 05:48 PM, Antoine Tremblay wrote: > In this v3 : > > The main change is that the functions breakpoint_from_pc and > breakpoint_from_kind are now called : breakpoint_kind_from_pc and > sw_breakpoint_from_kind. > > As suggested in : https://sourceware.org/ml/gdb-patches/2015-10/msg00287.html > > Thank you Pedro Thank you for working on this. > the patch set is really more clear now. I agree. > Thus the patchset is restructured for that, patches have been renamed and > reordered. I replied to all patches individually, and in general this all LGTM now. Feel free to push with the nits I pointed out fixed, if Yao is happy with it as well. Thanks, Pedro Alves