From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126836-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 88378 invoked by alias); 21 Oct 2015 11:19:06 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 88327 invoked by uid 89); 21 Oct 2015 11:19:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 21 Oct 2015 11:19:04 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id B26AA91348;	Wed, 21 Oct 2015 11:19:02 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9LBJ1m5014810;	Wed, 21 Oct 2015 07:19:02 -0400
Message-ID: <562774A5.9080403@redhat.com>
Date: Wed, 21 Oct 2015 12:04:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Antoine Tremblay <antoine.tremblay@ericsson.com>,        gdb-patches@sourceware.org
Subject: Re: [PATCH v3 3/5] Implement breakpoint_kind_from_pc and sw_breakpoint_from_kind for ARM in GDBServer.
References: <1445359685-2589-1-git-send-email-antoine.tremblay@ericsson.com> <1445359685-2589-4-git-send-email-antoine.tremblay@ericsson.com>
In-Reply-To: <1445359685-2589-4-git-send-email-antoine.tremblay@ericsson.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-10/txt/msg00400.txt.bz2

On 10/20/2015 05:48 PM, Antoine Tremblay wrote:

> +static int
> +arm_breakpoint_kind_from_pc (CORE_ADDR *pcptr)
> +{
> +  if (IS_THUMB_ADDR (*pcptr))
> +    {
> +      gdb_byte buf[2];
> +
> +      *pcptr = UNMAKE_THUMB_ADDR (*pcptr);
> +
> +      /* Check whether we are replacing a thumb2 32-bit instruction.  */
> +      if ((*the_target->read_memory) (*pcptr, buf, 2) == 0)
> +	{
> +	  unsigned short inst1 = 0;
> +
> +	  (*the_target->read_memory) (*pcptr, (gdb_byte *) &inst1, 2);
> +	  if (thumb_insn_size (inst1) == 4)
> +	    {
> +	      return ARM_BP_KIND_THUMB2;
> +	    }

Unnecessary braces.

> +	}
> +      return ARM_BP_KIND_THUMB;
> +    }
> +  else
> +    {
> +      return ARM_BP_KIND_ARM;
> +    }

Unnecessary braces.

Otherwise LGTM.

Thanks,
Pedro Alves