From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87037 invoked by alias); 21 Oct 2015 11:18:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87024 invoked by uid 89); 21 Oct 2015 11:18:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 21 Oct 2015 11:18:44 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 9038F461EA; Wed, 21 Oct 2015 11:18:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9LBIg1L014676; Wed, 21 Oct 2015 07:18:42 -0400 Message-ID: <56277491.6070807@redhat.com> Date: Wed, 21 Oct 2015 11:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH v3 1/5] Add the target_ops needed for software breakpoints in GDBServer. References: <1445359685-2589-1-git-send-email-antoine.tremblay@ericsson.com> <1445359685-2589-2-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1445359685-2589-2-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00398.txt.bz2 On 10/20/2015 05:48 PM, Antoine Tremblay wrote: > --- a/gdb/gdbserver/linux-low.h > +++ b/gdb/gdbserver/linux-low.h > @@ -141,8 +141,17 @@ struct linux_target_ops > > CORE_ADDR (*get_pc) (struct regcache *regcache); > void (*set_pc) (struct regcache *regcache, CORE_ADDR newpc); > - const unsigned char *breakpoint; > - int breakpoint_len; > + > + /* Return the breakpoint kind for this target based on PC. The PCPTR is > + adjusted to the real memory location in case a flag (e.g., the Thumb bit on > + ARM) was present in the PC. */ Spurious double space before "was present". > + int (*breakpoint_kind_from_pc) (CORE_ADDR *pcptr); > + > + /* Return the software breakpoint from KIND. KIND can have target > + specific meaning like the z0 kind parameter. It's more usual to talk in terms of the "insert" packet. That is, write uppercase Z0. > --- a/gdb/gdbserver/target.h > +++ b/gdb/gdbserver/target.h > @@ -441,6 +441,16 @@ struct target_ops > readlink(2). */ > ssize_t (*multifs_readlink) (int pid, const char *filename, > char *buf, size_t bufsiz); > + > + /* Return the breakpoint kind for this target based on PC. The PCPTR is > + adjusted to the real memory location in case a flag (e.g., the Thumb bit on > + ARM) was present in the PC. */ > + int (*breakpoint_kind_from_pc) (CORE_ADDR *pcptr); > + > + /* Return the software breakpoint from KIND. KIND can have target > + specific meaning like the z0 kind parameter. > + SIZE is set to the software breakpoint's length in memory. */ > + const gdb_byte *(*sw_breakpoint_from_kind) (int kind, int *size); Ditto. I think the linux-low.h comments should just say "See target.h for details." or some such, avoiding the duplication (and the forgetting to update linux-low.h when target.h next changes). Otherwise LGTM. Thanks, Pedro Alves