From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36963 invoked by alias); 20 Oct 2015 16:03:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36948 invoked by uid 89); 20 Oct 2015 16:03:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 20 Oct 2015 16:03:45 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 54E16C1A02B6; Tue, 20 Oct 2015 16:03:44 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9KG3gpw010990; Tue, 20 Oct 2015 12:03:43 -0400 Message-ID: <562665DE.1030104@redhat.com> Date: Tue, 20 Oct 2015 16:48:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Aleksandar Ristovski , "gdb-patches@sourceware.org" Subject: Re: [PATCH 2/3] (patch 2/4, v2) [nto] Implement TARGET_OBJECT_AUXV. References: <56263FED.3050602@redhat.com> <1445351294-18179-1-git-send-email-aristovski@qnx.com> <1445351294-18179-3-git-send-email-aristovski@qnx.com> <56265BB2.6060204@redhat.com> <562660E9.7000000@qnx.com> In-Reply-To: <562660E9.7000000@qnx.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00365.txt.bz2 On 10/20/2015 04:42 PM, Aleksandar Ristovski wrote: > On 15-10-20 11:20 AM, Pedro Alves wrote: >> Does this result in any visible improvement? I assume that >> at least, "info auxv" now works [1] [2]. It'd be really nice to have a >> blurb in the commit log mentioning what motivated this. > > Yes, info auxv works on a live process. For the core I have other > patches that need to go in first, but the mechanism of getting auxv > remains the same; only determining initial stack changes. OK, but please clarify or drop the misleading comment until those patches go in then. Please push with that fixed. > > I will add something to the commit log. > "Fix 'info auxv' for nto." Thanks. >> [1] - BTW, if you enable gdb.base/auxv.exp on NTO, does it pass? >> > > It fails since we have AT_* entries that are specific to nto, and get > printed as ??? which causes regex to not match. I have it patched > internally and print them out, but didn't think it would be acceptable > upstream. Why wouldn't it? If the issue is that the numbers conflict with other ports, then it can be handled with a gdbarch method. Thanks, Pedro Alves