From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45353 invoked by alias); 20 Oct 2015 15:24:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45330 invoked by uid 89); 20 Oct 2015 15:24:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 20 Oct 2015 15:24:04 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id A18A1354169; Tue, 20 Oct 2015 15:24:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9KFO2Ii012177; Tue, 20 Oct 2015 11:24:02 -0400 Message-ID: <56265C92.3010107@redhat.com> Date: Tue, 20 Oct 2015 15:25:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Aleksandar Ristovski , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] (patch 2/4, v2) [nto] Implement procfs_pid_to_exec_file. References: <56263FED.3050602@redhat.com> <1445351294-18179-1-git-send-email-aristovski@qnx.com> <1445351294-18179-4-git-send-email-aristovski@qnx.com> In-Reply-To: <1445351294-18179-4-git-send-email-aristovski@qnx.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00362.txt.bz2 On 10/20/2015 03:28 PM, Aleksandar Ristovski wrote: > gdb/ChangeLog: > > * gdb/nto-procfs.c (procfs_pid_to_exec_file): New function. > (init_procfs_targets): Wire new function. > --- > gdb/nto-procfs.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/gdb/nto-procfs.c b/gdb/nto-procfs.c > index ac54c32..e7882ba 100644 > --- a/gdb/nto-procfs.c > +++ b/gdb/nto-procfs.c > @@ -617,6 +617,33 @@ procfs_files_info (struct target_ops *ignore) > (nodestr != NULL) ? nodestr : "local node"); > } > > +/* Read executable file name for the given PID. */ > + Please write instead: /* Target to_pid_to_exec_file implementation. */ > +static char * > +procfs_pid_to_exec_file (struct target_ops *ops, const int pid) > +{ OK with that change. Thanks, Pedro Alves