From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59613 invoked by alias); 20 Oct 2015 15:03:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59602 invoked by uid 89); 20 Oct 2015 15:03:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 20 Oct 2015 15:02:56 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id E364BD0AA1; Tue, 20 Oct 2015 15:02:54 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9KF2rLK026651; Tue, 20 Oct 2015 11:02:54 -0400 Message-ID: <5626579D.4090900@redhat.com> Date: Tue, 20 Oct 2015 15:20:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Aleksandar Ristovski , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] (patch 2/4, v2) [nto] Fixes for nto procfs. References: <56263FED.3050602@redhat.com> <1445351294-18179-1-git-send-email-aristovski@qnx.com> <1445351294-18179-2-git-send-email-aristovski@qnx.com> In-Reply-To: <1445351294-18179-2-git-send-email-aristovski@qnx.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00360.txt.bz2 On 10/20/2015 03:28 PM, Aleksandar Ristovski wrote: > Fix errnoeus construction of procfs path. The issue is, after the first > info pidlist or first run, the path for local node (the most common node) > will be reset to empty which makes subsequent queries and runs impossible. Thanks. > > gdb/ChangeLog: > > * nto-procfs.c (nto_procfs_path): Rename to... > (nodestr): ... this, and change type. > (nto_node): Use new variable and logic accordingly. > (procfs_open_1): Use new variable name. Use local buffer to construct > procfrs path. > (procfs_pidlist): Use NODESTR to construct procfs path. > (procfs_files_info): Use NODESTR to output meaningful text. > (do_attach): Construct procfs using NODESTR. > (procfs_create_inferior): Compare pointer to NULL. This is OK. There are some bits here that seem a bit unrelated, but we're hitting the point of diminishing returns. Thanks, Pedro Alves