From: Luis Machado <lgustavo@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make GDB wait for events after handling target File-I/O
Date: Mon, 19 Oct 2015 13:37:00 -0000 [thread overview]
Message-ID: <5624F20F.9050201@codesourcery.com> (raw)
In-Reply-To: <5624EEFE.7010105@redhat.com>
On 10/19/2015 11:24 AM, Pedro Alves wrote:
> On 10/19/2015 02:21 PM, Luis Machado wrote:
>> On 10/19/2015 07:21 AM, Pedro Alves wrote:
>>> On 10/16/2015 08:30 PM, Luis Machado wrote:
>>>
>>>> How does the attached update look?
>>>
>>> Is there a reason to keep the "rs->waiting_for_stop_reply = 1;" lines?
>>
>> No, that was a mistake since we inverted the logic. What about the
>> following?
>>
>> Now we'll only set rs->waiting_for_stop_reply to 1 when resuming in
>> "all-stop" mode.
>>
>
> Thanks. This version LGTM.
>
Thanks. Pushed now as 29090fb629734b7980f058f4a7e24a0369e9bb49.
prev parent reply other threads:[~2015-10-19 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 0:58 Luis Machado
2015-09-10 12:59 ` Pedro Alves
2015-10-16 19:30 ` Luis Machado
2015-10-19 9:22 ` Pedro Alves
2015-10-19 13:22 ` Luis Machado
2015-10-19 13:24 ` Pedro Alves
2015-10-19 13:37 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5624F20F.9050201@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox